From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Eli Zaretskii <eliz@gnu.org>
Cc: perry@piermont.com, dancol@dancol.org, raeburn@raeburn.org,
monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Can we go GTK-only?
Date: Thu, 03 Nov 2016 12:43:18 +0900 [thread overview]
Message-ID: <wld1idi5yh.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <83mvhhnaul.fsf@gnu.org>
>>>>> On Wed, 02 Nov 2016 17:46:26 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> 1489 dispatch_group_async (group, queue, ^{
>> 1490 int nkeys;
>> 1491 uintptr_t key;
>> 1492 nkeys = nkeys_or_perm;
>> 1493 for (key = row * (256 / NGLYPHS_IN_VALUE); ; key++)
>> 1494 if (CFDictionaryContainsKey (dictionary,
>> 1495 (const void *) key))
>> 1496 {
>> 1497 CFDictionaryRemoveValue (dictionary,
>> 1498 (const void *) key);
>> 1499 if (--nkeys == 0)
>> 1500 break;
>> 1501 }
>> 1502 });
>>
>> I can disable this for NS if it does not fit with the current policy
>> of GNU Emacs mainline source code.
> I know next to nothing about NS. These are system APIs, right? If
> so, calling them could be okay, and I defer to NS and OS X people here
> to make that call.
They internally use malloc/free. What if the code like above were
using malloc/free instead of CF functions?
BTW, I just remember the current implementation of xfree should not be
used from a non-main thread if XMALLOC_BLOCK_INPUT_CHECK is defined.
The Mac port contains a code that calls "free" off the main thread for
some data that were allocated in the main thread.
void
mac_free_gc (GC gc)
{
CGColorRelease (gc->cg_fore_color);
CGColorRelease (gc->cg_back_color);
if (gc->clip_rects_data)
CFRelease (gc->clip_rects_data);
#if defined (XMALLOC_BLOCK_INPUT_CHECK) && DRAWING_USE_GCD
/* Don't use xfree here, because this might be called in a non-main
thread. */
free (gc);
#else
xfree (gc);
#endif
}
> One things bothers me, though: can't this arrangement, where data is
> allocated in one thread and deallocated in another, cause races? Or
> do these threads have means to synchronize between them?
For CFDictionary itself, its fundamental operations are thread-safe,
as well as malloc/free. For the font data structure that use
CFDictionary, the main thread waits for the other thread after doing
some independent tasks that do not use CFDictionary.
1543 if (group)
1544 {
1545 dispatch_group_wait (group, DISPATCH_TIME_FOREVER);
1546 dispatch_release (group);
1547 }
1548 }
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
next prev parent reply other threads:[~2016-11-03 3:43 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 19:54 Can we go GTK-only? Daniel Colascione
2016-10-27 20:05 ` Frank Haun
2016-10-27 20:45 ` Daniel Colascione
2016-10-27 21:08 ` Frank Haun
2016-10-27 20:32 ` Paul Eggert
2016-10-27 23:15 ` Perry E. Metzger
2016-10-28 7:13 ` Eli Zaretskii
2016-10-28 2:35 ` Richard Stallman
2016-10-28 6:22 ` Eli Zaretskii
2016-10-28 7:27 ` Ulrich Mueller
2016-10-28 8:15 ` Eli Zaretskii
2016-10-28 10:48 ` Frank Haun
2016-10-28 12:26 ` Eli Zaretskii
2016-10-28 13:35 ` Stefan Monnier
2016-10-30 14:43 ` Ken Raeburn
2016-10-30 21:42 ` Stefan Monnier
2016-10-30 22:49 ` Daniel Colascione
2016-10-30 23:57 ` Stefan Monnier
2016-10-31 3:37 ` Eli Zaretskii
2016-10-31 15:57 ` Eli Zaretskii
2016-10-31 0:00 ` YAMAMOTO Mitsuharu
2016-10-31 8:24 ` Ken Raeburn
2016-10-31 16:34 ` Perry E. Metzger
2016-11-01 8:22 ` YAMAMOTO Mitsuharu
2016-10-31 3:33 ` Eli Zaretskii
2016-10-31 15:57 ` Perry E. Metzger
2016-10-31 15:56 ` Eli Zaretskii
2016-10-31 15:59 ` Daniel Colascione
2016-10-31 16:47 ` Eli Zaretskii
2016-10-31 17:54 ` Perry E. Metzger
2016-10-31 20:50 ` Eli Zaretskii
2016-10-31 15:52 ` Eli Zaretskii
2016-10-31 15:54 ` Eli Zaretskii
2016-10-31 18:22 ` Ken Raeburn
2016-10-31 20:53 ` Eli Zaretskii
2016-10-31 21:04 ` Daniel Colascione
2016-11-01 15:11 ` Eli Zaretskii
2016-11-01 16:28 ` Paul Eggert
2016-11-01 16:49 ` Eli Zaretskii
2016-11-01 16:54 ` Daniel Colascione
2016-11-01 17:08 ` Eli Zaretskii
2016-11-01 17:16 ` Daniel Colascione
2016-11-01 19:15 ` Perry E. Metzger
2016-11-01 19:28 ` Lars Ingebrigtsen
2016-11-01 19:31 ` Eli Zaretskii
2016-11-01 16:55 ` Paul Eggert
2016-11-01 17:15 ` Perry E. Metzger
2016-11-01 16:41 ` Perry E. Metzger
2016-11-01 16:54 ` Eli Zaretskii
2016-11-01 17:22 ` Perry E. Metzger
2016-11-01 17:46 ` Eli Zaretskii
2016-11-01 17:56 ` Perry E. Metzger
2016-11-01 19:35 ` Perry E. Metzger
2016-11-01 16:45 ` Daniel Colascione
2016-11-01 17:01 ` Eli Zaretskii
2016-11-01 17:06 ` Daniel Colascione
2016-11-01 17:15 ` Eli Zaretskii
2016-11-01 17:18 ` Daniel Colascione
2016-11-01 17:44 ` Eli Zaretskii
2016-11-01 17:45 ` Daniel Colascione
2016-11-01 19:14 ` Stefan Monnier
2016-11-01 19:22 ` Eli Zaretskii
2016-11-01 19:42 ` Perry E. Metzger
2016-11-01 19:20 ` Perry E. Metzger
2016-11-01 20:05 ` Eli Zaretskii
2016-11-01 20:17 ` Daniel Colascione
2016-11-01 20:42 ` Eli Zaretskii
2016-11-02 2:26 ` Perry E. Metzger
2016-11-02 15:49 ` Eli Zaretskii
2016-11-02 15:55 ` Daniel Colascione
2016-11-02 5:00 ` YAMAMOTO Mitsuharu
2016-11-02 15:46 ` Eli Zaretskii
2016-11-03 3:43 ` YAMAMOTO Mitsuharu [this message]
2016-11-03 17:40 ` Eli Zaretskii
2016-11-02 0:27 ` Stefan Monnier
2016-11-02 15:53 ` Eli Zaretskii
2016-11-02 16:04 ` Stefan Monnier
2016-11-02 19:25 ` Nikolaus Rath
2016-11-02 20:33 ` Paul Eggert
2016-11-03 1:25 ` Richard Stallman
2016-11-02 19:25 ` Nikolaus Rath
2016-11-02 20:13 ` Eli Zaretskii
2016-11-03 3:29 ` Perry E. Metzger
2016-11-03 18:07 ` John Wiegley
2016-11-03 22:07 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wld1idi5yh.wl%mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=dancol@dancol.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=perry@piermont.com \
--cc=raeburn@raeburn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).