From: "T.V Raman" <raman@google.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510
Date: Sun, 13 Sep 2020 08:47:12 -0700 [thread overview]
Message-ID: <p91een5smpr.fsf@google.com> (raw)
In-Reply-To: <p91imchu26z.fsf@google.com> (T. V. Raman's message of "Sun, 13 Sep 2020 08:27:32 -0700")
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 1731 bytes --]
"T.V Raman" <raman@google.com> writes:
Could be a possible bug in propertize?
With the epub rendered in EWW buffer as current buffer:
In addition to the minibuffer eval results shown earlier,
(propertize (plist-get eww-data :title) 'face 'variable-pitch)
thorws the
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
which is the same error that eww-update-header-line threw,
while
(plist-get eww-data :title)
returns a string,
Both of the above evaluated in the relevant stack frame via "e"
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
> eww-update-header-line was seeing the title as nil which is what
> surprized me.
>
> So: with the rendered buffer as current buffer, evaluating these in the
> minibuffer:
>
> (plist-get eww-data :title) returned the title I had set, but evaluating
> (eww-update-header-line) in the minibuffer threw an error, with the
> debugger showing that propertize had been called with a null string > "T.V Raman" <raman@google.com> writes:
>>
>>> I'm setting eww-data correctly, and plist-get shows that :title is set
>>> correctly in eww-data when I go to the buffer where the ebook is
>>> rendered. However eww-update-header-line throws an error on this line:
>>>
>>> + (let ((title (propertize (plist-get eww-data :title)
>>>
>>> appears that plist-get in the above call returns nil within
>>> eww-update-header-line --not sure why
>>
>> If that bugs out, then :title in eww-data can't be a string, I think?
>>
>> But I see that the old code supported a nil value for title, so I've now
>> tweaked the code a bit to avoid bugging out in this case. Pushed to the
>> trunk now.
--
7©4 Id: kg:/m/0285kf1 0Ü8
next prev parent reply other threads:[~2020-09-13 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 14:22 eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510 T.V Raman
2020-09-13 15:08 ` Lars Ingebrigtsen
2020-09-13 15:27 ` T.V Raman
2020-09-13 15:47 ` T.V Raman [this message]
2020-09-13 16:20 ` Lars Ingebrigtsen
2020-09-13 16:43 ` T.V Raman
2020-09-13 16:47 ` Lars Ingebrigtsen
2020-09-13 16:52 ` Lars Ingebrigtsen
2020-09-13 17:48 ` T.V Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p91een5smpr.fsf@google.com \
--to=raman@google.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).