From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510 Date: Sun, 13 Sep 2020 08:47:12 -0700 Message-ID: References: <24414.11044.596033.388237@google.com> <87363llnou.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=gb18030 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2660"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 13 17:48:28 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHUEu-0000bH-Ie for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 17:48:28 +0200 Original-Received: from localhost ([::1]:45642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHUEn-0001qY-N8 for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 11:48:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHUDm-0000HR-P2 for emacs-devel@gnu.org; Sun, 13 Sep 2020 11:47:18 -0400 Original-Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:39259) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHUDk-0007uE-W9 for emacs-devel@gnu.org; Sun, 13 Sep 2020 11:47:18 -0400 Original-Received: by mail-pj1-x1035.google.com with SMTP id v14so2779129pjd.4 for ; Sun, 13 Sep 2020 08:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=RHU1ywgoKWE09JO3rALAjtSLrwgeAmVgKIiUzyp7Sro=; b=CYgbfDls5U/xAuocUNkUH6uz0rVa+vy39/tkIK6fLz62wz3uRG4e3AhjU+AbFcdU5p L5JdbT3t7BC/mgXT5tUkwUHbr/OVrX1PtHZUNgUnNfm3WevRZn3XeYiP593vzd+5n/+Q 2EukcqtW7N0+U245qWTZ1NQH7YZeV4xtWoedBECi3DozoCLdWs9Q4JetooniLMRvZCtU /VI0q1G14kPpW7neXWPppr19taLTOxyBuAsb6MOHXG8nPm9WfDIE/5uk4L4TxxVBZRk5 KUTG9djdvwDnteqJ8AwFfnHF1MNYJwsxAxjv0PUYwXLw7ZfwIpI6KYCxxh/0IKv7pAUP PMOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=RHU1ywgoKWE09JO3rALAjtSLrwgeAmVgKIiUzyp7Sro=; b=ZgN2nQ4S4sGrMRMSny5u6RsQ/vCHcUk4aJ1d5ys/pQ+loJNgN4oix6oNkmk8LE3EYy ZLKUplLhsoKlHF4D22dLMr5nDSVv7ESuA2QmJyJWO/x7jtD0ab+Q51rtDnwNHNQtdsTF oBI7pqwam6pk7rz6zfolBYqe3pHY1CLgcFiQNjE8q67gXgMrTDYtxuDftKon40QtHvGY u8CABLhA5wIFvMKwNy5zz/SDQbzPtzAwG3WWaBYzHEQ44hi9MrikUh85DZPdf38y9nw9 bPynOr6E/u7zLN5yEO5CZAWSfVIrfMWY80U3M5PkERvSNysGwVw1qhQux+u08V03Ars6 iL7Q== X-Gm-Message-State: AOAM530HsOPsYg3W5GcOxQdvTM+uJYQsj3KcmhnG6HuuhOs4GTKWWXcn 9bYS7dqZ41UOdOmyJU1wSl/Hj4w5hDpK3tE9 X-Google-Smtp-Source: ABdhPJzYMWpP0H05XmeZCu0SujfVaGFKcWQZ750mgVfgc7V640aDQ9B8j0xrkOkorn2utbHGHMvoJg== X-Received: by 2002:a17:902:b090:: with SMTP id p16mr10407145plr.20.1600012034660; Sun, 13 Sep 2020 08:47:14 -0700 (PDT) Original-Received: from raman-glaptop.localdomain (c-24-4-174-65.hsd1.ca.comcast.net. [24.4.174.65]) by smtp.gmail.com with ESMTPSA id co3sm1198520pjb.31.2020.09.13.08.47.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 08:47:13 -0700 (PDT) Original-Received: by raman-glaptop.localdomain (Postfix, from userid 13930) id AB74FC217BB; Sun, 13 Sep 2020 08:47:12 -0700 (PDT) In-Reply-To: (T. V. Raman's message of "Sun, 13 Sep 2020 08:27:32 -0700") Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=raman@google.com; helo=mail-pj1-x1035.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255513 Archived-At: "T.V Raman" writes: Could be a possible bug in propertize? With the epub rendered in EWW buffer as current buffer: In addition to the minibuffer eval results shown earlier, (propertize (plist-get eww-data :title) 'face 'variable-pitch) thorws the Debugger entered--Lisp error: (wrong-type-argument stringp nil) which is the same error that eww-update-header-line threw, while (plist-get eww-data :title) returns a string, Both of the above evaluated in the relevant stack frame via "e" > Lars Ingebrigtsen writes: > > eww-update-header-line was seeing the title as nil which is what > surprized me. > > So: with the rendered buffer as current buffer, evaluating these in the > minibuffer: > > (plist-get eww-data :title) returned the title I had set, but evaluating > (eww-update-header-line) in the minibuffer threw an error, with the > debugger showing that propertize had been called with a null string > "= T.V Raman" writes: >> >>> I'm setting eww-data correctly, and plist-get shows that :title is set >>> correctly in eww-data when I go to the buffer where the ebook is >>> rendered. However eww-update-header-line throws an error on this line: >>> >>> + (let ((title (propertize (plist-get eww-data :title) >>> >>> appears that plist-get in the above call returns nil within >>> eww-update-header-line --not sure why=20 >> >> If that bugs out, then :title in eww-data can't be a string, I think? >> >> But I see that the old code supported a nil value for title, so I've now >> tweaked the code a bit to avoid bugging out in this case. Pushed to the >> trunk now. --=20 =817=A94 Id: kg:/m/0285kf1 =950=DC8