unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "T.V Raman" <raman@google.com>
To: emacs-devel@gnu.org
Subject: eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510
Date: Sun, 13 Sep 2020 07:22:28 -0700	[thread overview]
Message-ID: <24414.11044.596033.388237@google.com> (raw)

eww-update-header-line has changed to apply variable-pitch to the
header as of d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510.

This seems to work correctly when browsing Web sites, but it's
breaking in my ebook handler.

I'm setting eww-data correctly, and plist-get shows that :title is set
correctly in eww-data when I go to the buffer where the ebook is
rendered. However eww-update-header-line throws an error on this line:

+	     (let ((title (propertize (plist-get eww-data :title)

  appears that  plist-get in the above call returns nil within
       eww-update-header-line --not sure why 
-- 
♉ Id: kg:/m/0285kf1  🦮

--
♉ Id: kg:/m/0285kf1  🦮



             reply	other threads:[~2020-09-13 14:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-13 14:22 T.V Raman [this message]
2020-09-13 15:08 ` eww-update-header-line: Possible breakage after d39ae6f5860ecf6ebbeedc08bf3aafa5befaf510 Lars Ingebrigtsen
2020-09-13 15:27   ` T.V Raman
2020-09-13 15:47     ` T.V Raman
2020-09-13 16:20       ` Lars Ingebrigtsen
2020-09-13 16:43         ` T.V Raman
2020-09-13 16:47           ` Lars Ingebrigtsen
2020-09-13 16:52             ` Lars Ingebrigtsen
2020-09-13 17:48           ` T.V Raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24414.11044.596033.388237@google.com \
    --to=raman@google.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).