From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at.
Date: Mon, 12 Aug 2013 17:32:12 +0200 [thread overview]
Message-ID: <m3siyfx6v7.fsf@stories.gnus.org> (raw)
In-Reply-To: <E1V8tmX-0001uj-Of@vcs.savannah.gnu.org> (Juanma Barranquero's message of "Mon, 12 Aug 2013 15:11:41 +0000")
Juanma Barranquero <lekktu@gmail.com> writes:
> +2013-08-12 Juanma Barranquero <lekktu@gmail.com>
> +
> + * xml.el (xml-parse-tag-1): Use looking-at (this reverts change in
> + revno:113793, which breaks the test suite).
> + https://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00263.html
[...]
> - (while (not (looking-at-p end))
> + (while (not (looking-at end))
Wouldn't it be better to fix the bogus test instead of changing
apparently perfectly good code (for the (slightly) worse)?
That's the danger of test suites. >"?
--
(domestic pets only, the antidote for overdose, milk.)
No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php
and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html
next parent reply other threads:[~2013-08-12 15:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1V8tmX-0001uj-Of@vcs.savannah.gnu.org>
2013-08-12 15:32 ` Lars Magne Ingebrigtsen [this message]
2013-08-12 15:41 ` trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at Juanma Barranquero
2013-08-12 16:18 ` Lars Magne Ingebrigtsen
2013-08-12 16:26 ` Juanma Barranquero
2013-08-12 16:29 ` Glenn Morris
2013-08-12 16:47 ` Lars Magne Ingebrigtsen
2013-08-13 1:46 ` Stefan Monnier
2013-08-13 2:55 ` Juanma Barranquero
2013-08-13 12:10 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3siyfx6v7.fsf@stories.gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).