From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at. Date: Mon, 12 Aug 2013 17:32:12 +0200 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376321631 28325 80.91.229.3 (12 Aug 2013 15:33:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 12 Aug 2013 15:33:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 12 17:33:54 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V8u82-0005CM-4N for ged-emacs-devel@m.gmane.org; Mon, 12 Aug 2013 17:33:54 +0200 Original-Received: from localhost ([::1]:60671 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8u81-0002ZJ-OC for ged-emacs-devel@m.gmane.org; Mon, 12 Aug 2013 11:33:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8u7s-0002YM-1r for emacs-devel@gnu.org; Mon, 12 Aug 2013 11:33:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8u7l-0000P7-SF for emacs-devel@gnu.org; Mon, 12 Aug 2013 11:33:43 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:54960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8u7l-0000Ol-Lp for emacs-devel@gnu.org; Mon, 12 Aug 2013 11:33:37 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1V8u6O-0006JW-Vz; Mon, 12 Aug 2013 17:32:13 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEVTLCB+byLUzqtoEhxS CRZqVyOekTyOfykca34FAAACeUlEQVQ4jW3US4/aMBAA4Emx4Yq7IrlW0W7O2Q50r5GYVa8OG4cr po1zJa2I/37HTqBU6kgI259fEyZAXrgYvVdKhY8yxuj8GYyplcqUy0arUueddapzAbqutTbN3Mgw 9n1hreo6fX4GV6TKpilvFqG3zna9YTA2tS7twyaewQ7KblQEPi4b/C0G7m5MhPofCNdiOX+JK0LM C0DycIQ6bnUHooTzmGBThx14MMBKvEM1g66yoakyv5YMdUNEMoBSQiRKUOKBMu/bhqobaC1rShLf XhPvNYOU5tcLg7kmRqd11p7w1bdWJyeYALS5HIt+2P3G8rosXNJMK8yiBHh32QU5zDI3Yovy8wts uEuE6njlxn53OJ8EYnUoQIeJe8SkQ9zud+254U75qYAFhgFEed22glBKEWZG+MAtN3fGue5p1xDi awT+/tjGc/PiMGRhyg/Erzmg2E+Au25JFaL4/lTSp5yLYR9H3Qd+46xNuFQJhxzUZhEu9eZO+7ef BBBuIyMoEQ9HQRSBm9oEGBqkkAo/btpW8TQ5Aw/E9InicXzBO8Tu9gblBL65TcRyhmkrtYZH4HU3 0HfgZ0ZAxLm1eSgGuZ+HGapEANQBjFozBKJ9ucCKM+Gk44q14QdGnAcylJXaTMCH+yuKimFRPmGZ cBEoFYErEIXUVC2wqbQ0Gz0BV5knkRgQi13zTivvLz5CqGWSKw1rsdKmPjJkN3BiNV6OFqrauTG+ JekM3dJdRmck/+59H4qegY8YnW3dyTk1vfDO+SHLwQfo0wAc4/xn4HMYfOzwa3wH3o1X2AnmeFhh s/FRbpFD7++dc/4QUOT/D/jbLJwxADTHH5LYHA4R2fnrAAAAAElFTkSuQmCC X-Now-Playing: Yellow Magic Orchestra's _Solid State Survivor_: "Behind the Mask" X-Hashcash: 1:23:130812:emacs-devel@gnu.org::1JCDSd95AeUEZ3VH:000000000000000000000000000000000000000000GFti X-Hashcash: 1:23:130812:lekktu@gmail.com::uIO2nwcxAWpqvl7R:0g53R In-Reply-To: (Juanma Barranquero's message of "Mon, 12 Aug 2013 15:11:41 +0000") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-MailScanner-ID: 1V8u6O-0006JW-Vz MailScanner-NULL-Check: 1376926335.64548@Z66MxYDCe9FaFm7oR9GFpA X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162620 Archived-At: Juanma Barranquero writes: > +2013-08-12 Juanma Barranquero > + > + * xml.el (xml-parse-tag-1): Use looking-at (this reverts change in > + revno:113793, which breaks the test suite). > + https://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00263.html [...] > - (while (not (looking-at-p end)) > + (while (not (looking-at end)) Wouldn't it be better to fix the bogus test instead of changing apparently perfectly good code (for the (slightly) worse)? That's the danger of test suites. >"? -- (domestic pets only, the antidote for overdose, milk.) No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html