unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: Emacs developers <emacs-devel@gnu.org>,
	Juanma Barranquero <lekktu@gmail.com>
Subject: Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at.
Date: Mon, 12 Aug 2013 21:46:46 -0400	[thread overview]
Message-ID: <jwvtxiupdo0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m3ob92c0vd.fsf@stories.gnus.org> (Lars Magne Ingebrigtsen's message of "Mon, 12 Aug 2013 18:47:18 +0200")

>> What's that you say... "gee, my eyes have been opened as to the value of
>> test-suites, and I will start writing one for Gnus forthwith"? ;)
> That's what I've been doing the past half hour!

Not sure if that means you've been saying it reeeaalllly sslllooowww or
repeating it over and over, but in case it doesn't sound like a useful
use of your time.

BTW, another thing to learn for this is that we shouldn't bother to
replace looking-at with looking-at-p.

It can be handy to use looking-at-p if it saves us from using
save-match-data, but other than that it's not worth the trouble.


        Stefan



  reply	other threads:[~2013-08-13  1:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1V8tmX-0001uj-Of@vcs.savannah.gnu.org>
2013-08-12 15:32 ` trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at Lars Magne Ingebrigtsen
2013-08-12 15:41   ` Juanma Barranquero
2013-08-12 16:18     ` Lars Magne Ingebrigtsen
2013-08-12 16:26       ` Juanma Barranquero
2013-08-12 16:29       ` Glenn Morris
2013-08-12 16:47         ` Lars Magne Ingebrigtsen
2013-08-13  1:46           ` Stefan Monnier [this message]
2013-08-13  2:55             ` Juanma Barranquero
2013-08-13 12:10             ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtxiupdo0.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).