unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Simplify Gnus buffer liveness checking and killing
Date: Mon, 20 May 2019 13:58:54 +0200	[thread overview]
Message-ID: <m3k1el72wx.fsf@gnus.org> (raw)
In-Reply-To: <87d0kdl4yf.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 20 May 2019 12:51:04 +0100")

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> I assume you're referring to the following changes:
>
>> * lisp/gnus/gnus-agent.el (gnus-agent-synchronize-group-flags):
>> Fix indentation.
>> * lisp/gnus/gnus-win.el (gnus-delete-windows-in-gnusey-frames)
>> (gnus-remove-some-windows): Simplify.
>
> If so, I can commit them separately (assuming they're welcome).

Sorry; I totally confused myself -- I started looking at a different
Gnus diff in the middle of reading your email.  :-/

I think your changes look very reasonable, but I haven't tested.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2019-05-20 11:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20  0:10 [PATCH] Simplify Gnus buffer liveness checking and killing Basil L. Contovounesios
2019-05-20 10:51 ` Lars Ingebrigtsen
2019-05-20 11:51   ` Basil L. Contovounesios
2019-05-20 11:58     ` Lars Ingebrigtsen [this message]
2019-05-20 12:29       ` Basil L. Contovounesios
2019-05-20 21:43 ` Eric Abrahamsen
2019-05-20 22:19   ` Basil L. Contovounesios
2019-05-20 22:48     ` Eric Abrahamsen
2019-05-30  2:21     ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3k1el72wx.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).