From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: [PATCH] Simplify Gnus buffer liveness checking and killing
Date: Mon, 20 May 2019 15:48:00 -0700 [thread overview]
Message-ID: <871s0swxnj.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87d0kcrcp0.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 20 May 2019 23:19:39 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>>
>>> There seems to be overlap in the implementations and usage of
>>> gnus-buffer-exists-p and gnus-buffer-live-p, as well as of gnus-buffers
>>> and gnus-prune-buffers.
>>>
>>> The attached patch removes gnus-buffer-exists-p in favour of a modified
>>> gnus-buffer-live-p, aliases gnus-prune-buffers to a simplified
>>> gnus-buffers, and simplifies several call sites pertaining to buffer
>>> liveness checking and killing. WDYT?
>>
>> I've been running this most of today; nothing terrible has happened so
>> far.
>
> Thanks for testing.
>
>> Can I suggest adding `gnus-buffer-exists-p' back in as a
>> `define-obsolete-function-alias' for `gnus-buffer-live-p'?
>
> Drats, I was hoping to get away with that one. ;)
Nope, there'll always be someone to complain :)
>> I assume that will work for macros.
>
> Yes, so long as the macroexpansion sites are recompiled.
>
>> Anyway, it would just be nicer for people who, ahem, have external
>> packages that were using that function.
>
> I could have sworn I checked GNU ELPA before removing it... Probably
> got mixed up with some other branch I had on the back-burner, sorry.
No worries! Looks like my gnorb package was the only one using it, anyway.
next prev parent reply other threads:[~2019-05-20 22:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 0:10 [PATCH] Simplify Gnus buffer liveness checking and killing Basil L. Contovounesios
2019-05-20 10:51 ` Lars Ingebrigtsen
2019-05-20 11:51 ` Basil L. Contovounesios
2019-05-20 11:58 ` Lars Ingebrigtsen
2019-05-20 12:29 ` Basil L. Contovounesios
2019-05-20 21:43 ` Eric Abrahamsen
2019-05-20 22:19 ` Basil L. Contovounesios
2019-05-20 22:48 ` Eric Abrahamsen [this message]
2019-05-30 2:21 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s0swxnj.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).