From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Simplify Gnus buffer liveness checking and killing
Date: Mon, 20 May 2019 12:51:04 +0100 [thread overview]
Message-ID: <87d0kdl4yf.fsf@tcd.ie> (raw)
In-Reply-To: <m3pnod760t.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 20 May 2019 12:51:46 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> The attached patch removes gnus-buffer-exists-p in favour of a modified
>> gnus-buffer-live-p, aliases gnus-prune-buffers to a simplified
>> gnus-buffers, and simplifies several call sites pertaining to buffer
>> liveness checking and killing. WDYT?
>
> The patch included a lot of stuff that didn't seem to have anything to
> do with buffer liveness and checking...
I assume you're referring to the following changes:
> * lisp/gnus/gnus-agent.el (gnus-agent-synchronize-group-flags):
> Fix indentation.
> * lisp/gnus/gnus-win.el (gnus-delete-windows-in-gnusey-frames)
> (gnus-remove-some-windows): Simplify.
If so, I can commit them separately (assuming they're welcome).
If not, I would be grateful for elaboration on which parts of the patch
you're not okay with.
Thanks,
--
Basil
next prev parent reply other threads:[~2019-05-20 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 0:10 [PATCH] Simplify Gnus buffer liveness checking and killing Basil L. Contovounesios
2019-05-20 10:51 ` Lars Ingebrigtsen
2019-05-20 11:51 ` Basil L. Contovounesios [this message]
2019-05-20 11:58 ` Lars Ingebrigtsen
2019-05-20 12:29 ` Basil L. Contovounesios
2019-05-20 21:43 ` Eric Abrahamsen
2019-05-20 22:19 ` Basil L. Contovounesios
2019-05-20 22:48 ` Eric Abrahamsen
2019-05-30 2:21 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0kdl4yf.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).