Re: master 60c9702972f: * lisp/help.el (help--analyze-key): Use `help-fns-function-name`

Re: master 60c9702972f: * lisp/help.el (help--analyze-key): Use `help-fns-function-name`

[Arash Esbati]

Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

> branch: master
> commit 60c9702972f3cef9e6dbbce5eaad8cc90ea7f8e8
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     * lisp/help.el (help--analyze-key): Use `help-fns-function-name`
> ---
>  lisp/help.el | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/help.el b/lisp/help.el
> index 4171d0c57c7..bafe6032942 100644
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -926,7 +926,9 @@ in the selected window."
>       (let ((key-desc (help-key-description key untranslated)))
>         (if (help--binding-undefined-p defn)
>             (format "%s%s is undefined" key-desc mouse-msg)
> -         (format "%s%s runs the command %S" key-desc mouse-msg defn)))
> +         (format "%s%s runs the command %s" key-desc mouse-msg
> +                 (if (symbolp defn) (prin1-to-string defn)
> +                   (help-fns-function-name defn)))))
>       defn event mouse-msg)))
>  
>  (defun help--filter-info-list (info-list i)

I think this change now produces:

  In end of data:
  help.el:931:21: Warning: the function ‘help-fns-function-name’ is not
  known to be defined.

This is with Emacs 30 (87be53846b) on macOS.

Best, Arash

Re: master 60c9702972f: * lisp/help.el (help--analyze-key): Use `help-fns-function-name`

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sat, 30 Mar 2024 12:19:23 +0100
> 
> I think this change now produces:
> 
>   In end of data:
>   help.el:931:21: Warning: the function ‘help-fns-function-name’ is not
>   known to be defined.

This is not a real problem: after you build once, touch lisp.help.el
and build again: the warning will be gone.  That's because the
autoload form for the function will be written to loaddefs.el.

Re: master 60c9702972f: * lisp/help.el (help--analyze-key): Use `help-fns-function-name`

[Arash Esbati]

Eli Zaretskii <eliz@gnu.org> writes:

> This is not a real problem: after you build once, touch lisp.help.el
> and build again: the warning will be gone.  That's because the
> autoload form for the function will be written to loaddefs.el.

Thanks, does this also apply to a clean state repo?  I use a small
script to build Emacs which does:

  git clean -fdx --exclude=ChangeLog
  ./autogen.sh
  ./configure ...

My lisp/loaddefs.el already has an entry:

  $ grep help-fns-function loaddefs.el
  (autoload 'help-fns-function-name "help-fns" "\

I didn't change anything after my initial build where I reported the
warning.

Best, Arash

Re: master 60c9702972f: * lisp/help.el (help--analyze-key): Use `help-fns-function-name`

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Cc: emacs-devel@gnu.org,  monnier@iro.umontreal.ca
> Date: Sat, 30 Mar 2024 16:45:02 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > This is not a real problem: after you build once, touch lisp.help.el
> > and build again: the warning will be gone.  That's because the
> > autoload form for the function will be written to loaddefs.el.
> 
> Thanks, does this also apply to a clean state repo?  I use a small
> script to build Emacs which does:
> 
>   git clean -fdx --exclude=ChangeLog
>   ./autogen.sh
>   ./configure ...
> 
> My lisp/loaddefs.el already has an entry:
> 
>   $ grep help-fns-function loaddefs.el
>   (autoload 'help-fns-function-name "help-fns" "\
> 
> I didn't change anything after my initial build where I reported the
> warning.

No clue, sorry.  I got the warning upon the first build after update
from upstream, then the next build didn't have the warning.

Re: master 60c9702972f: * lisp/help.el (help--analyze-key): Use `help-fns-function-name`

[Stefan Monnier]

>> This is not a real problem: after you build once, touch lisp.help.el
>> and build again: the warning will be gone.  That's because the
>> autoload form for the function will be written to loaddefs.el.
> Thanks, does this also apply to a clean state repo?

What Eli is saying is that the warning will disappear the next time
`ldefs-boot.el` is updated with a more current copy of `loaddefs.el`.


        Stefan

Re: master 60c9702972f: * lisp/help.el (help--analyze-key): Use `help-fns-function-name`

[Arash Esbati]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> What Eli is saying is that the warning will disappear the next time
> `ldefs-boot.el` is updated with a more current copy of `loaddefs.el`.

Thanks Stefan, so I'll wait for that.

Best, Arash