From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arash Esbati Newsgroups: gmane.emacs.devel Subject: Re: master 60c9702972f: * lisp/help.el (help--analyze-key): Use `help-fns-function-name` Date: Sat, 30 Mar 2024 12:19:23 +0100 Message-ID: References: <171107186434.18812.2389706590800223024@vcs2.savannah.gnu.org> <20240322014425.180EEC12C52@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35461"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 30 12:20:02 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqWkj-0008xw-PN for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Mar 2024 12:20:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqWkD-0007bC-It; Sat, 30 Mar 2024 07:19:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqWkB-0007Yx-6s for emacs-devel@gnu.org; Sat, 30 Mar 2024 07:19:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqWkA-0001YL-8D; Sat, 30 Mar 2024 07:19:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=4NxcXxPnMST2V2O5JqOCBAlbdesKScThNYk4snpW+IM=; b=KQBSQKfSwEBn9lD2bkZE O7wIW2Br6FsAR5NkF0cvvjfU0CpruzM++2iXC8GEVAoro8AfKnmMHXBJ6RtKex5kvRuvCDYCxUvVb ij/qb3d60Qom6DMOsuVaLMG7QDJ9bNGmOeSP/LWXytQ1Y2dTBfwmvv7WKy74g4mRCdmQjAFc23kQ1 /GfIwKtAF7J92ZWM8aM5vM7aYHo7ce2eYKwbd6CP93EmyS5Bu7pnwMQIAmFh8CEQX2AQzsU3Ktf9H OvaRWtM1sjVyuad94YK9nIZv+JhjLxEABnERrnKFUPT0Dmzfbuhi8Jk7s6nKCDJeA/OdlJDwXzMjy G2Phh75q4sCs5g==; In-Reply-To: <20240322014425.180EEC12C52@vcs2.savannah.gnu.org> (Stefan Monnier via Mailing list for Emacs changes's message of "Thu, 21 Mar 2024 21:44:24 -0400 (EDT)") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317393 Archived-At: Stefan Monnier via Mailing list for Emacs changes wri= tes: > branch: master > commit 60c9702972f3cef9e6dbbce5eaad8cc90ea7f8e8 > Author: Stefan Monnier > Commit: Stefan Monnier > > * lisp/help.el (help--analyze-key): Use `help-fns-function-name` > --- > lisp/help.el | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lisp/help.el b/lisp/help.el > index 4171d0c57c7..bafe6032942 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -926,7 +926,9 @@ in the selected window." > (let ((key-desc (help-key-description key untranslated))) > (if (help--binding-undefined-p defn) > (format "%s%s is undefined" key-desc mouse-msg) > - (format "%s%s runs the command %S" key-desc mouse-msg defn))) > + (format "%s%s runs the command %s" key-desc mouse-msg > + (if (symbolp defn) (prin1-to-string defn) > + (help-fns-function-name defn))))) > defn event mouse-msg))) >=20=20 > (defun help--filter-info-list (info-list i) I think this change now produces: In end of data: help.el:931:21: Warning: the function =E2=80=98help-fns-function-name=E2= =80=99 is not known to be defined. This is with Emacs 30 (87be53846b) on macOS. Best, Arash