* bug#23372: 25.0.93; text-quoting-style missing from manual and from customize
[not found] ` <83eg9rzh3q.fsf@gnu.org>
@ 2016-04-27 19:10 ` John Wiegley
2016-04-28 21:45 ` Kaushal Modi
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: John Wiegley @ 2016-04-27 19:10 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: nljlistbox2, 23372, emacs-devel
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
> It is easy to make a variable into a defcustom; the inverse is generally
> much harder.
That _is_ a rather strong argument...
The main reason I'd like a customization option along with the introduction of
the feature, is that it's a departure from *very* long-standiing practice, so
unless you happen to like Unicode quotes, I'm predicting that several people
will want a way to get back the sort of display they've been used to seeing
since antiquity.
Do any others object to having a customization option along with release of
the feature? I'm cross-posting this to Emacs-devel to get more opinions.
The question is: Should `text-quoting-style' be customizable in 25.1, or
should it be a variable, thus requiring Lisp code to change it for now?
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: bug#23372: 25.0.93; text-quoting-style missing from manual and from customize
2016-04-27 19:10 ` bug#23372: 25.0.93; text-quoting-style missing from manual and from customize John Wiegley
@ 2016-04-28 21:45 ` Kaushal Modi
2016-04-29 21:22 ` John Wiegley
2016-04-29 10:37 ` bug#23365 and Org-mode for 25.1 Phillip Lord
2016-04-29 12:54 ` bug#23372: 25.0.93; text-quoting-style missing from manual and from customize Nicolas Petton
2 siblings, 1 reply; 8+ messages in thread
From: Kaushal Modi @ 2016-04-28 21:45 UTC (permalink / raw)
To: Eli Zaretskii, 23372, nljlistbox2, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]
>
> Do any others object to having a customization option along with release of
> the feature? I'm cross-posting this to Emacs-devel to get more opinions.
>
> The question is: Should `text-quoting-style' be customizable in 25.1, or
> should it be a variable, thus requiring Lisp code to change it for now?
>
If a user's opinion counts, I now like the curved quotes (thanks Paul and
others!). The quotes look great! There was initial resistance from my side
as I saw a lot of inconsistencies. But by now, all the inconsistencies that
at least I saw are resolved. Earlier I wanted to switch back to quotes
being displayed as ` and ', but not anymore :).
So I do not mind the quotes being displayed curly by default and that
option still not being a defcustom.
If we see a lot of emacs users unhappy because of this, then may be this is
converted to defcustom in 25.2? Because as Eli said:
> It is easy to make a variable into a defcustom; the inverse is generally
> much harder.
--
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 1508 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#23365 and Org-mode for 25.1
2016-04-27 19:10 ` bug#23372: 25.0.93; text-quoting-style missing from manual and from customize John Wiegley
2016-04-28 21:45 ` Kaushal Modi
@ 2016-04-29 10:37 ` Phillip Lord
2016-04-29 21:23 ` John Wiegley
2016-04-29 12:54 ` bug#23372: 25.0.93; text-quoting-style missing from manual and from customize Nicolas Petton
2 siblings, 1 reply; 8+ messages in thread
From: Phillip Lord @ 2016-04-29 10:37 UTC (permalink / raw)
To: emacs-devel
I've submitted a bug recently on org-mode (#23365) which is present in
Emacs-25 head, but has been fixed in the org-mode on ELPA.
Is org-mode in core going to be sync'd before 25.1?
Phil
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: bug#23372: 25.0.93; text-quoting-style missing from manual and from customize
2016-04-27 19:10 ` bug#23372: 25.0.93; text-quoting-style missing from manual and from customize John Wiegley
2016-04-28 21:45 ` Kaushal Modi
2016-04-29 10:37 ` bug#23365 and Org-mode for 25.1 Phillip Lord
@ 2016-04-29 12:54 ` Nicolas Petton
2 siblings, 0 replies; 8+ messages in thread
From: Nicolas Petton @ 2016-04-29 12:54 UTC (permalink / raw)
To: John Wiegley, Eli Zaretskii; +Cc: nljlistbox2, 23372, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
John Wiegley <jwiegley@gmail.com> writes:
> The question is: Should `text-quoting-style' be customizable in 25.1, or
> should it be a variable, thus requiring Lisp code to change it for
> now?
I think I'd go for a defcustom.
Nico
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: bug#23372: 25.0.93; text-quoting-style missing from manual and from customize
2016-04-28 21:45 ` Kaushal Modi
@ 2016-04-29 21:22 ` John Wiegley
0 siblings, 0 replies; 8+ messages in thread
From: John Wiegley @ 2016-04-29 21:22 UTC (permalink / raw)
To: Kaushal Modi; +Cc: nljlistbox2, Eli Zaretskii, 23372, emacs-devel
>>>>> Kaushal Modi <kaushal.modi@gmail.com> writes:
> If we see a lot of emacs users unhappy because of this, then may be this is
> converted to defcustom in 25.2? Because as Eli said:
OK, I'm fine with that, as it seems the path of greatest caution.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: bug#23365 and Org-mode for 25.1
2016-04-29 10:37 ` bug#23365 and Org-mode for 25.1 Phillip Lord
@ 2016-04-29 21:23 ` John Wiegley
2016-04-30 7:48 ` Phillip Lord
0 siblings, 1 reply; 8+ messages in thread
From: John Wiegley @ 2016-04-29 21:23 UTC (permalink / raw)
To: Phillip Lord; +Cc: emacs-devel
>>>>> Phillip Lord <phillip.lord@russet.org.uk> writes:
> I've submitted a bug recently on org-mode (#23365) which is present in
> Emacs-25 head, but has been fixed in the org-mode on ELPA.
> Is org-mode in core going to be sync'd before 25.1?
No, I've spoken to the Org-mode maintainer about this, and it's too late in
the game for such a large upgrade. Org 8.3 has some rather major changes, and
we haven't had it in enough pretests to know what the impact will be now.
However, it's welcome in 25.2.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: bug#23365 and Org-mode for 25.1
2016-04-29 21:23 ` John Wiegley
@ 2016-04-30 7:48 ` Phillip Lord
2016-04-30 7:51 ` John Wiegley
0 siblings, 1 reply; 8+ messages in thread
From: Phillip Lord @ 2016-04-30 7:48 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
John Wiegley <jwiegley@gmail.com> writes:
>>>>>> Phillip Lord <phillip.lord@russet.org.uk> writes:
>
>> I've submitted a bug recently on org-mode (#23365) which is present in
>> Emacs-25 head, but has been fixed in the org-mode on ELPA.
>
>> Is org-mode in core going to be sync'd before 25.1?
>
> No, I've spoken to the Org-mode maintainer about this, and it's too late in
> the game for such a large upgrade. Org 8.3 has some rather major changes, and
> we haven't had it in enough pretests to know what the impact will be now.
> However, it's welcome in 25.2.
Okay, no worries.
I've made a patch based on this commit:
http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=44c8cd7136e3fcd1e6bfa08895cac437b7a691fa
identifed by Kaushal Modi on the org-mode mailing list.
Is it okay to apply this backport to emacs-25
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-map-entries-Fix-org-agenda-prepare-buffers-call.patch --]
[-- Type: text/x-diff, Size: 1421 bytes --]
From 51d927a6479fdfca1ef58086d4fd70f394238f7d Mon Sep 17 00:00:00 2001
From: Phillip Lord <phillip.lord@newcastle.ac.uk>
Date: Sat, 30 Apr 2016 08:43:39 +0100
Subject: [PATCH] org-map-entries: Fix org-agenda-prepare-buffers call
* lisp/org.el (org-map-entries): Check that buffer-file-name is non-nil
before passing to org-agenda-prepare-buffers.
This is a backport of commit 44c8cd7136e3fcd1e6bfa08895cac437b7a691fa
from upstream org-mode. Addresses bug #23365.
---
lisp/org/org.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/org/org.el b/lisp/org/org.el
index 231daa9..61bcb45 100644
--- a/lisp/org/org.el
+++ b/lisp/org/org.el
@@ -15069,7 +15069,7 @@ org-map-entries
(if (not scope)
(progn
(org-agenda-prepare-buffers
- (list (buffer-file-name (current-buffer))))
+ (and buffer-file-name (list buffer-file-name)))
(setq res (org-scan-tags func matcher todo-only start-level)))
;; Get the right scope
(cond
@@ -15081,7 +15081,7 @@ org-map-entries
(setq scope (org-agenda-files t))
(setq scope (org-add-archive-files scope)))
((eq scope 'file)
- (setq scope (list (buffer-file-name))))
+ (setq scope (and buffer-file-name (list buffer-file-name))))
((eq scope 'file-with-archives)
(setq scope (org-add-archive-files (list (buffer-file-name))))))
(org-agenda-prepare-buffers scope)
--
2.8.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: bug#23365 and Org-mode for 25.1
2016-04-30 7:48 ` Phillip Lord
@ 2016-04-30 7:51 ` John Wiegley
0 siblings, 0 replies; 8+ messages in thread
From: John Wiegley @ 2016-04-30 7:51 UTC (permalink / raw)
To: Phillip Lord; +Cc: emacs-devel
>>>>> Phillip Lord <phillip.lord@russet.org.uk> writes:
> Is it okay to apply this backport to emacs-25
Yes, looks good to me, thanks.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-04-30 7:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87wpnlq1xu.fsf@gmail.com>
[not found] ` <eb307773-2842-57fc-1246-962f9f5eda84@cs.ucla.edu>
[not found] ` <cd466f56-0733-48c2-8431-d082ae877014@default>
[not found] ` <83lh40287l.fsf@gnu.org>
[not found] ` <m2twinhqcz.fsf@newartisans.com>
[not found] ` <83eg9rzh3q.fsf@gnu.org>
2016-04-27 19:10 ` bug#23372: 25.0.93; text-quoting-style missing from manual and from customize John Wiegley
2016-04-28 21:45 ` Kaushal Modi
2016-04-29 21:22 ` John Wiegley
2016-04-29 10:37 ` bug#23365 and Org-mode for 25.1 Phillip Lord
2016-04-29 21:23 ` John Wiegley
2016-04-30 7:48 ` Phillip Lord
2016-04-30 7:51 ` John Wiegley
2016-04-29 12:54 ` bug#23372: 25.0.93; text-quoting-style missing from manual and from customize Nicolas Petton
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).