Re: bug#48548: 28.0.50; Some process attributes on macOS are missing

Re: bug#48548: 28.0.50; Some process attributes on macOS are missing

[Filipp Gunbin]

Hello, could someone please review this? (bug#48548)

I'm kinda sure in syscalls I make (tested them on latest Big Sur 11.3.1
and on Yosemite from several years ago; running with this patch for
several weeks now, using via M-x proced), but I'm not so sure in my C
:-)

Thanks.

Re: bug#48548: 28.0.50; Some process attributes on macOS are missing

[Eli Zaretskii]

> From: Filipp Gunbin <fgunbin@fastmail.fm>
> Date: Thu, 20 May 2021 23:49:54 +0300
> Cc: bug-gnu-emacs@gnu.org
> 
> Hello, could someone please review this? (bug#48548)

Please be more patient: you posted the patch just 10 minutes before
sending this ping.  The patch will be reviewed soon enough, just give
us some time.

Thanks.

Re: bug#48548: 28.0.50; Some process attributes on macOS are missing

[Filipp Gunbin]

On 21/05/2021 08:53 +0300, Eli Zaretskii wrote:

>> From: Filipp Gunbin <fgunbin@fastmail.fm>
>> Date: Thu, 20 May 2021 23:49:54 +0300
>> Cc: bug-gnu-emacs@gnu.org
>>
>> Hello, could someone please review this? (bug#48548)
>
> Please be more patient: you posted the patch just 10 minutes before
> sending this ping.  The patch will be reviewed soon enough, just give
> us some time.
>
> Thanks.

Pinging wasn't my intent, I just wanted to ask for review on
emacs-devel..

Thanks.

Re: bug#48548: 28.0.50; Some process attributes on macOS are missing

[Eli Zaretskii]

> From: Filipp Gunbin <fgunbin@fastmail.fm>
> Date: Fri, 21 May 2021 12:50:50 +0300
> Cc: bug-gnu-emacs@gnu.org, emacs-devel@gnu.org
> 
> Pinging wasn't my intent, I just wanted to ask for review on
> emacs-devel..

Cross-posting on both bug-gnu-emacs and emacs-devel is generally not a
good idea, so please try not to do that in the future.  The people who
are likely to review your patch are reading the bug list anyway.

Re: bug#48548: 28.0.50; Some process attributes on macOS are missing

[Filipp Gunbin]

On 21/05/2021 13:27 +0300, Eli Zaretskii wrote:

>> From: Filipp Gunbin <fgunbin@fastmail.fm>
>> Date: Fri, 21 May 2021 12:50:50 +0300
>> Cc: bug-gnu-emacs@gnu.org, emacs-devel@gnu.org
>>
>> Pinging wasn't my intent, I just wanted to ask for review on
>> emacs-devel..
>
> Cross-posting on both bug-gnu-emacs and emacs-devel is generally not a
> good idea, so please try not to do that in the future.  The people who
> are likely to review your patch are reading the bug list anyway.

Yes, I know that crossposting is not generally appreciated, but in this
case it's a bit different: I'm not posting the same message, rather I'm
creating a bug as a container for patch (I wanted to try debbugs
package, although I failed to do it properly, and the tagging message
went without patch - now I see where I was wrong, I didn't select the
commit _range_ with debbugs-gnu-pick-commits, but rather just a commit),
and the review request as an actual message.

What is best to do such things in the future?  Just post a bug with tag
"patch", or just directly post patch to emacs-devel?  I don't want to
cause inconvenience, sorry for this time.

Filipp

Re: bug#48548: 28.0.50; Some process attributes on macOS are missing

[Eli Zaretskii]

> From: Filipp Gunbin <fgunbin@fastmail.fm>
> Cc: emacs-devel@gnu.org
> Date: Fri, 21 May 2021 15:30:38 +0300
> 
> Yes, I know that crossposting is not generally appreciated, but in this
> case it's a bit different: I'm not posting the same message, rather I'm
> creating a bug as a container for patch (I wanted to try debbugs
> package, although I failed to do it properly, and the tagging message
> went without patch - now I see where I was wrong, I didn't select the
> commit _range_ with debbugs-gnu-pick-commits, but rather just a commit),
> and the review request as an actual message.
> 
> What is best to do such things in the future?  Just post a bug with tag
> "patch", or just directly post patch to emacs-devel?  I don't want to
> cause inconvenience, sorry for this time.

Just post to the bug list and wait for responses.  If you see no
responses in a week or two, ping the bug list.  If that doesn't
receive any responses, either, ask on emacs-devel about the bug.

It is rare to have a patch unanswered for a prolonged time, unless
it's in some very obscure part of Emacs.

Re: bug#48548: 28.0.50; Some process attributes on macOS are missing

[Filipp Gunbin]

On 21/05/2021 15:33 +0300, Eli Zaretskii wrote:

>> From: Filipp Gunbin <fgunbin@fastmail.fm>
>> Cc: emacs-devel@gnu.org
>> Date: Fri, 21 May 2021 15:30:38 +0300
>>
>> Yes, I know that crossposting is not generally appreciated, but in this
>> case it's a bit different: I'm not posting the same message, rather I'm
>> creating a bug as a container for patch (I wanted to try debbugs
>> package, although I failed to do it properly, and the tagging message
>> went without patch - now I see where I was wrong, I didn't select the
>> commit _range_ with debbugs-gnu-pick-commits, but rather just a commit),
>> and the review request as an actual message.
>>
>> What is best to do such things in the future?  Just post a bug with tag
>> "patch", or just directly post patch to emacs-devel?  I don't want to
>> cause inconvenience, sorry for this time.
>
> Just post to the bug list and wait for responses.  If you see no
> responses in a week or two, ping the bug list.  If that doesn't
> receive any responses, either, ask on emacs-devel about the bug.

You mean normal M-x report-emacs-bug, or just posting to the list?

Re: bug#48548: 28.0.50; Some process attributes on macOS are missing

[Eli Zaretskii]

> From: Filipp Gunbin <fgunbin@fastmail.fm>
> Date: Fri, 21 May 2021 15:36:34 +0300
> Cc: emacs-devel@gnu.org
> 
> > Just post to the bug list and wait for responses.  If you see no
> > responses in a week or two, ping the bug list.  If that doesn't
> > receive any responses, either, ask on emacs-devel about the bug.
> 
> You mean normal M-x report-emacs-bug, or just posting to the list?

It doesn't matter much, when you are posting a patch.  Up to you.

Re: bug#48548: 28.0.50; Some process attributes on macOS are missing

[Eli Zaretskii]

> Date: Fri, 21 May 2021 15:45:12 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> > You mean normal M-x report-emacs-bug, or just posting to the list?
> 
> It doesn't matter much, when you are posting a patch.  Up to you.

Of course, if the patch is accompanied by a report of a bug, then
report-emacs-bug is better, since it collects data that could be
relevant for analyzing the bug.

Re: bug#48548: 28.0.50; Some process attributes on macOS are missing

[Filipp Gunbin]

On 21/05/2021 15:45 +0300, Eli Zaretskii wrote:

>> From: Filipp Gunbin <fgunbin@fastmail.fm>
>> Date: Fri, 21 May 2021 15:36:34 +0300
>> Cc: emacs-devel@gnu.org
>>
>> > Just post to the bug list and wait for responses.  If you see no
>> > responses in a week or two, ping the bug list.  If that doesn't
>> > receive any responses, either, ask on emacs-devel about the bug.
>>
>> You mean normal M-x report-emacs-bug, or just posting to the list?
>
> It doesn't matter much, when you are posting a patch.  Up to you.

Thanks!

Re: bug#48548: 28.0.50; Some process attributes on macOS are missing

[Basil L. Contovounesios]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Fri, 21 May 2021 15:45:12 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: emacs-devel@gnu.org
>> 
>> > You mean normal M-x report-emacs-bug, or just posting to the list?
>> 
>> It doesn't matter much, when you are posting a patch.  Up to you.
>
> Of course, if the patch is accompanied by a report of a bug, then
> report-emacs-bug is better, since it collects data that could be
> relevant for analyzing the bug.

FWIW, Emacs 28 adds yet another alternative:

*** New command 'submit-emacs-patch'.
This works like 'report-emacs-bug', but is more geared towards sending
patches to the Emacs issue tracker.

-- 
Basil