Re: master e720ba62193 1/2: (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events

Re: master e720ba62193 1/2: (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events

[Eshel Yaron]

Hi Stefan,

Stefan Monnier writes:

> branch: master
> commit e720ba6219394d275dd741c5f17feea1ee0bf9af
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events
>
>     Change the handling of the old X11 convention that uses mouse-4/5/6/7
>     events to represent wheel events: instead of asking downstream
>     packages to use the `mouse-wheel-*-event` variables to know which events
>     represent wheel events, use new var `mouse-wheel-buttons` to directly
>     convert those events into the standard `wheel-up/down/left/right` events
>     used everywhere else.
>
>     This will simplify the work of packages which can thus just bind their
>     commands to `wheel-up/down/left/right`.

[...]

> diff --git a/lisp/completion-preview.el b/lisp/completion-preview.el
> index a86c1ba1cc9..a1e0abe2e14 100644
> --- a/lisp/completion-preview.el
> +++ b/lisp/completion-preview.el
> @@ -139,9 +139,13 @@ If this option is nil, these commands do not display any message."
>    ;; and vice versa!!
>    "<wheel-up>"     #'completion-preview-prev-candidate
>    "<wheel-down>"   #'completion-preview-next-candidate
> -  (key-description (vector mouse-wheel-up-event))
> +  (key-description (with-suppressed-warnings
> +                       ((obsolete mouse-wheel-up-event))
> +                     (vector mouse-wheel-up-event)))
>    #'completion-preview-next-candidate
> -  (key-description (vector mouse-wheel-down-event))
> +  (key-description (with-suppressed-warnings
> +                       ((obsolete mouse-wheel-down-event))
> +                     (vector mouse-wheel-down-event)))
>    #'completion-preview-prev-candidate)

I wonder whether/why we should keep the bindings that use
mouse-wheel-up/down-event here.  Do I understand correctly that since we
already bind wheel-down/up directly, we should now be able to simply
remove these additional bindings?


Thanks,

Eshel

Re: master e720ba62193 1/2: (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events

[Stefan Monnier]

> I wonder whether/why we should keep the bindings that use
> mouse-wheel-up/down-event here.  Do I understand correctly that since we
> already bind wheel-down/up directly, we should now be able to simply
> remove these additional bindings?

I had an earlier patch which was "more radical" in this way, but in the
end went with this half-way patch where people can set
`mouse-wheel-buttons` to nil and recover the old behavior.

We could remove most of those (if not all) uses of
`mouse-wheel-up/down/left/right-event`, but I don't think there's
a hurry to do that.

Admittedly, the ones in `completion-preview.el` could go because they're
new in Emacs-30 so there's no previous behavior to preserve.


        Stefan

Re: master e720ba62193 1/2: (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events

[Eshel Yaron]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I wonder whether/why we should keep the bindings that use
>> mouse-wheel-up/down-event here.  Do I understand correctly that since we
>> already bind wheel-down/up directly, we should now be able to simply
>> remove these additional bindings?
>
> I had an earlier patch which was "more radical" in this way, but in the
> end went with this half-way patch where people can set
> `mouse-wheel-buttons` to nil and recover the old behavior.
>
> We could remove most of those (if not all) uses of
> `mouse-wheel-up/down/left/right-event`, but I don't think there's
> a hurry to do that.

Got it, thanks.

> Admittedly, the ones in `completion-preview.el` could go because they're
> new in Emacs-30 so there's no previous behavior to preserve.

Indeed.  I think I'll remove them then, that way we won't need to
require mwheel in completion-preview.el anymore :)

Re: master e720ba62193 1/2: (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events

[Stefan Monnier]

>> Admittedly, the ones in `completion-preview.el` could go because they're
>> new in Emacs-30 so there's no previous behavior to preserve.
> Indeed.  I think I'll remove them then, that way we won't need to
> require mwheel in completion-preview.el anymore :)

Sounds good,


        Stefan