From: Eshel Yaron <me@eshelyaron.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master e720ba62193 1/2: (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events
Date: Wed, 10 Apr 2024 20:35:26 +0200 [thread overview]
Message-ID: <m1cyqxrrpt.fsf@dazzs-mbp.kpn> (raw)
In-Reply-To: <jwvjzl66zqp.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 09 Apr 2024 16:39:57 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I wonder whether/why we should keep the bindings that use
>> mouse-wheel-up/down-event here. Do I understand correctly that since we
>> already bind wheel-down/up directly, we should now be able to simply
>> remove these additional bindings?
>
> I had an earlier patch which was "more radical" in this way, but in the
> end went with this half-way patch where people can set
> `mouse-wheel-buttons` to nil and recover the old behavior.
>
> We could remove most of those (if not all) uses of
> `mouse-wheel-up/down/left/right-event`, but I don't think there's
> a hurry to do that.
Got it, thanks.
> Admittedly, the ones in `completion-preview.el` could go because they're
> new in Emacs-30 so there's no previous behavior to preserve.
Indeed. I think I'll remove them then, that way we won't need to
require mwheel in completion-preview.el anymore :)
next prev parent reply other threads:[~2024-04-10 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171267304154.21960.14298364323940508129@vcs2.savannah.gnu.org>
[not found] ` <20240409143042.278CDC12C36@vcs2.savannah.gnu.org>
2024-04-09 17:29 ` master e720ba62193 1/2: (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events Eshel Yaron
2024-04-09 20:39 ` Stefan Monnier
2024-04-10 18:35 ` Eshel Yaron [this message]
2024-04-10 18:52 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1cyqxrrpt.fsf@dazzs-mbp.kpn \
--to=me@eshelyaron.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).