From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] Flymake support for C/C++
Date: Sat, 02 Jun 2018 13:16:20 -0400 [thread overview]
Message-ID: <jwvzi0dp18m.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 20180601210708.GA6771@ACM
> I've had another look at your proposed cc-flymake.el. It doesn't use
> any CC Mode interfaces or data structures. It uses lots of flymake
> interfaces and data structures. It has nothing to do with CC Mode's
> source files; it is an integral part of flymake, and should be called
> something like flymake-cc.el and maintained together with the rest of
> flymake.
I agree that it's not specific to CC-mode.
It should also work for several languages not supported by CC-mode,
for example. Maybe it'd be better to think of it as "flymake support
for GNU tools" (e.g. it relies on the GNU Coding Standard format of
error/warning messages).
But I think that the part of the code which tells flymake to use
this "flymake for GNU tools" code does belong with c-mode.
> Imenu support (in cc-menus.el) isn't really part of CC Mode either, but
> is there by tradition.
That makes it sound like you'd rather remove imenu support from CC-mode.
I think that would be a disservice to (y)our users.
For the same reason I think cc-mode should incorporate something like
(add-hook 'flymake-diagnostic-functions #'flymake-cc nil t)
in its code. Just as is the case for Imenu code, you (as maintainer of
CC-mode) don't really have to actively support the code, you just accept
to keep it under your roof as long as it doesn't misbehave.
Stefan
next prev parent reply other threads:[~2018-06-02 17:16 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 15:09 [PATCH] Flymake support for C/C++ João Távora
2017-10-12 15:50 ` Mark Oteiza
2017-10-12 17:50 ` Alan Mackenzie
2017-10-12 18:45 ` Stefan Monnier
2017-10-12 20:45 ` Alan Mackenzie
2017-10-12 21:03 ` Stefan Monnier
2017-10-13 6:28 ` Eli Zaretskii
2017-10-12 18:46 ` João Távora
2017-10-12 20:39 ` Alan Mackenzie
2017-10-12 21:05 ` Stefan Monnier
2017-10-12 21:24 ` João Távora
2018-06-01 21:07 ` Alan Mackenzie
2018-06-01 21:54 ` João Távora
2018-06-01 22:08 ` Stefan Monnier
2018-06-01 23:23 ` Rolf Ade
2018-06-02 10:33 ` Alan Mackenzie
2018-06-02 14:44 ` Stefan Monnier
2018-06-02 18:13 ` João Távora
2018-06-03 15:45 ` Alan Mackenzie
2018-06-03 16:28 ` João Távora
2018-06-03 16:43 ` Alan Mackenzie
2018-06-03 17:02 ` João Távora
2018-06-02 17:16 ` Stefan Monnier [this message]
2018-06-02 15:26 ` Stefan Monnier
2018-06-03 13:44 ` Alan Mackenzie
2017-10-14 1:34 ` Richard Stallman
2017-10-14 7:10 ` Reuben Thomas
2017-10-14 7:58 ` Sami Kerola
2017-10-14 8:00 ` Eli Zaretskii
2017-10-14 8:15 ` Reuben Thomas
2017-10-14 8:22 ` Dmitry Gutov
2017-10-14 8:29 ` Reuben Thomas
2017-10-14 10:36 ` Eli Zaretskii
2017-10-14 11:22 ` Reuben Thomas
2017-10-14 8:33 ` Eli Zaretskii
2017-10-17 10:53 ` Phillip Lord
2017-10-17 10:56 ` Reuben Thomas
2017-10-18 4:03 ` Richard Stallman
2017-10-18 10:18 ` Reuben Thomas
2017-10-19 3:26 ` Richard Stallman
2017-10-19 7:38 ` Reuben Thomas
2017-10-22 23:18 ` Richard Stallman
2017-10-22 23:23 ` Reuben Thomas
2017-10-24 4:12 ` Richard Stallman
2017-10-24 9:45 ` Reuben Thomas
2017-10-24 9:48 ` Dmitry Gutov
2017-10-24 9:52 ` Reuben Thomas
2017-10-24 9:57 ` Dmitry Gutov
2017-10-24 10:07 ` Reuben Thomas
2017-10-24 10:21 ` Dmitry Gutov
2017-10-24 10:28 ` Reuben Thomas
2017-10-24 15:44 ` Stefan Monnier
2017-10-25 19:30 ` Richard Stallman
2017-10-27 0:43 ` Reuben Thomas
2017-10-28 21:47 ` Richard Stallman
2017-10-18 12:16 ` Clément Pit-Claudel
2017-10-18 17:30 ` John Wiegley
2017-10-14 13:55 ` Stefan Monnier
2017-10-14 9:33 ` João Távora
2017-10-14 10:56 ` guillaume papin
2017-10-14 16:29 ` João Távora
2017-10-14 16:36 ` Reuben Thomas
2017-10-18 12:22 ` Clément Pit-Claudel
2017-10-18 14:26 ` João Távora
2017-10-14 9:29 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzi0dp18m.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).