From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Flymake support for C/C++ Date: Sat, 02 Jun 2018 13:16:20 -0400 Message-ID: References: <87zi8wmmhw.fsf@gmail.com> <20171012175044.GA6106@ACM> <87tvz4mcg3.fsf@gmail.com> <20171012203953.GB6106@ACM> <87infkm53o.fsf@gmail.com> <20180601210708.GA6771@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1527959710 5865 195.159.176.226 (2 Jun 2018 17:15:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 2 Jun 2018 17:15:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 02 19:15:06 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPA7O-0001Pk-6G for ged-emacs-devel@m.gmane.org; Sat, 02 Jun 2018 19:15:06 +0200 Original-Received: from localhost ([::1]:60468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPA9V-0003DP-0G for ged-emacs-devel@m.gmane.org; Sat, 02 Jun 2018 13:17:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPA8s-0003D8-5E for emacs-devel@gnu.org; Sat, 02 Jun 2018 13:16:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPA8n-0003rC-6j for emacs-devel@gnu.org; Sat, 02 Jun 2018 13:16:38 -0400 Original-Received: from [195.159.176.226] (port=38430 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPA8m-0003qa-VY for emacs-devel@gnu.org; Sat, 02 Jun 2018 13:16:33 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fPA6b-0000Qc-L3 for emacs-devel@gnu.org; Sat, 02 Jun 2018 19:14:17 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 32 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:zEijr/WtpQcMhn2aMMPxon4egUg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225926 Archived-At: > I've had another look at your proposed cc-flymake.el. It doesn't use > any CC Mode interfaces or data structures. It uses lots of flymake > interfaces and data structures. It has nothing to do with CC Mode's > source files; it is an integral part of flymake, and should be called > something like flymake-cc.el and maintained together with the rest of > flymake. I agree that it's not specific to CC-mode. It should also work for several languages not supported by CC-mode, for example. Maybe it'd be better to think of it as "flymake support for GNU tools" (e.g. it relies on the GNU Coding Standard format of error/warning messages). But I think that the part of the code which tells flymake to use this "flymake for GNU tools" code does belong with c-mode. > Imenu support (in cc-menus.el) isn't really part of CC Mode either, but > is there by tradition. That makes it sound like you'd rather remove imenu support from CC-mode. I think that would be a disservice to (y)our users. For the same reason I think cc-mode should incorporate something like (add-hook 'flymake-diagnostic-functions #'flymake-cc nil t) in its code. Just as is the case for Imenu code, you (as maintainer of CC-mode) don't really have to actively support the code, you just accept to keep it under your roof as long as it doesn't misbehave. Stefan