From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@linkov.net>
Cc: emacs-devel@gnu.org
Subject: Re: master 12409c9: New transient mode 'repeat-mode' to allow shorter key sequences (bug#46515)
Date: Wed, 17 Feb 2021 23:39:44 -0500 [thread overview]
Message-ID: <jwvwnv6803o.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20210217180507.C061220DFB@vcs0.savannah.gnu.org> (Juri Linkov's message of "Wed, 17 Feb 2021 13:05:07 -0500 (EST)")
Hi Jury,
> +(defvar next-error-repeat-map
> + (let ((map (make-sparse-keymap)))
> + (define-key map "n" 'next-error)
> + (define-key map "\M-n" 'next-error)
> + (define-key map "p" 'previous-error)
> + (define-key map "\M-p" 'previous-error)
> + map)
> + "Keymap to repeat next-error key sequences. Used in `repeat-mode'.")
> +(put 'next-error 'repeat-map 'next-error-repeat-map)
> +(put 'previous-error 'repeat-map 'next-error-repeat-map)
Could we avoid this duplication between the map and the
`repeat-map` property?
> + (set-transient-map map)))))))
For example passing a second argument t to `set-transient-map` makes
`set-transient-map` look to see if the key just typed was found in the
map and if so keep the transient alive, which seems to [after an
admittedly cursory check of the code] play the same role as what your
`repeat-map` property does, but without the duplication.
Stefan
next parent reply other threads:[~2021-02-18 4:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210217180506.28704.14280@vcs0.savannah.gnu.org>
[not found] ` <20210217180507.C061220DFB@vcs0.savannah.gnu.org>
2021-02-18 4:39 ` Stefan Monnier [this message]
2021-02-18 9:37 ` master 12409c9: New transient mode 'repeat-mode' to allow shorter key sequences (bug#46515) Juri Linkov
2021-02-18 15:32 ` Stefan Monnier
2021-02-18 17:29 ` Juri Linkov
2021-02-23 22:08 ` Stefan Monnier
2021-02-24 18:45 ` Juri Linkov
2021-02-24 18:58 ` Stefan Monnier
2021-02-24 19:44 ` Juri Linkov
2021-02-24 20:53 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwnv6803o.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).