From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 12409c9: New transient mode 'repeat-mode' to allow shorter key sequences (bug#46515) Date: Wed, 17 Feb 2021 23:39:44 -0500 Message-ID: References: <20210217180506.28704.14280@vcs0.savannah.gnu.org> <20210217180507.C061220DFB@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11550"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 18 05:40:29 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCb77-0002uQ-3e for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 05:40:29 +0100 Original-Received: from localhost ([::1]:47062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCb76-00070W-4l for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 23:40:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCb6Z-0006bP-F3 for emacs-devel@gnu.org; Wed, 17 Feb 2021 23:39:55 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46331) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCb6W-0003vP-Mo for emacs-devel@gnu.org; Wed, 17 Feb 2021 23:39:54 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 257F010021B; Wed, 17 Feb 2021 23:39:51 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 86EFB100018; Wed, 17 Feb 2021 23:39:45 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1613623185; bh=lcEdpbGFgF0eS1bLDE+2WpfODNZdaJNmTPDVeamLchY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZkmRhz3PtdnFVYI1zVxZgVkxa/X7ArgcxJg7nj8UVmWyvp/EKJmToQN0/Omm6nR1r PQclzBJ9gAVg+Sbo5PKvHXUNBc3Pn+yjpv+TQ3mDg/Dv8HuJdLE6gfGrNUo/EkmFGC EKleg4i0hU4zDe0vHxq14dfZlbiHoT/MCFmMHpW9uf3nmzr5HN+qS+NcIpQlD4PTjW ez8RIdEKP0+SvZEHvagr0nJZXtVw5AZOpptNtRhxBt2CeY2VHteXBBjjzMSIXy5pIc kf7WTxZq/HuAsKVwJojcvtBG9GR2UDxQjAwUPZyqZEbLJAgSiovgu39ok6l0X/2kys 1wqyBOIZn9UBQ== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C91B112020B; Wed, 17 Feb 2021 23:39:44 -0500 (EST) In-Reply-To: <20210217180507.C061220DFB@vcs0.savannah.gnu.org> (Juri Linkov's message of "Wed, 17 Feb 2021 13:05:07 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265122 Archived-At: Hi Jury, > +(defvar next-error-repeat-map > + (let ((map (make-sparse-keymap))) > + (define-key map "n" 'next-error) > + (define-key map "\M-n" 'next-error) > + (define-key map "p" 'previous-error) > + (define-key map "\M-p" 'previous-error) > + map) > + "Keymap to repeat next-error key sequences. Used in `repeat-mode'.") > +(put 'next-error 'repeat-map 'next-error-repeat-map) > +(put 'previous-error 'repeat-map 'next-error-repeat-map) Could we avoid this duplication between the map and the `repeat-map` property? > + (set-transient-map map))))))) For example passing a second argument t to `set-transient-map` makes `set-transient-map` look to see if the key just typed was found in the map and if so keep the transient alive, which seems to [after an admittedly cursory check of the code] play the same role as what your `repeat-map` property does, but without the duplication. Stefan