Re: master 12409c9: New transient mode 'repeat-mode' to allow shorter key sequences (bug#46515)

[Juri Linkov <juri@linkov.net>]

>>>>>> +(defvar next-error-repeat-map
>>>>>> +  (let ((map (make-sparse-keymap)))
>>>>>> +    (define-key map    "n" 'next-error)
>>>>>> +    (define-key map "\M-n" 'next-error)
>>>>>> +    (define-key map    "p" 'previous-error)
>>>>>> +    (define-key map "\M-p" 'previous-error)
>>>>>> +    map)
>>>>>> +  "Keymap to repeat next-error key sequences.  Used in `repeat-mode'.")
>>>>>> +(put 'next-error 'repeat-map 'next-error-repeat-map)
>>>>>> +(put 'previous-error 'repeat-map 'next-error-repeat-map)
>>>>>
>>>>> Could we avoid this duplication between the map and the
>>>>> `repeat-map` property?
>>>
>>> There is in the above code snippet: the `put` statements are redundant
>>> since the same info is fundamentally already available from
>>> `next-error-repeat-map`.
>>
>> Now I see where is duplication.  But currently I have no idea
>> in what keymaps post-command-hook should look for keybindings.
>
> I don't see the problem: since your code installs the keymap, it can
> also arrange to stash the info of which keymap to look up.

In

  (put 'next-error 'repeat-map 'next-error-repeat-map)
  (put 'previous-error 'repeat-map 'next-error-repeat-map)

both next-error and previous-error are entry points to
a repeatable key sequence, i.e. both can start a key sequence:

  M-g n n p ...
  M-g p p n ...