From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitri Paduchikh <dpaduchikh@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Lexical byte-compilation warnings cleanup
Date: Thu, 22 Aug 2013 16:41:52 -0400 [thread overview]
Message-ID: <jwvvc2xbgvj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8761uypb7g.fsf@dpaduchikh.invalid> (Dmitri Paduchikh's message of "Thu, 22 Aug 2013 11:05:07 +0600")
> IMO, this does not explain what happens actually. I would rather prefer
> such variant:
> Warning: Lexically bound argument shadows dynamic variable %s
Better, indeed, thank you,
Stefan
=== modified file 'lisp/emacs-lisp/cconv.el'
--- lisp/emacs-lisp/cconv.el 2013-06-14 02:31:28 +0000
+++ lisp/emacs-lisp/cconv.el 2013-08-22 20:41:05 +0000
@@ -552,7 +552,8 @@
(cond
((byte-compile-not-lexical-var-p arg)
(byte-compile-log-warning
- (format "Argument %S is not a lexical variable" arg)))
+ (format "Lexical argument shadows the dynamic variable %S"
+ arg)))
((eq ?& (aref (symbol-name arg) 0)) nil) ;Ignore &rest, &optional, ...
(t (let ((varstruct (list arg nil nil nil nil)))
(cl-pushnew arg byte-compile-lexical-variables)
next prev parent reply other threads:[~2013-08-22 20:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 23:12 Lexical byte-compilation warnings cleanup Barry OReilly
2013-08-22 5:05 ` Dmitri Paduchikh
2013-08-22 20:41 ` Stefan Monnier [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-19 23:33 Daniel Hackney
2013-08-20 0:01 ` Juanma Barranquero
2013-08-20 0:11 ` Glenn Morris
2013-08-20 5:47 ` Stefan Monnier
2013-08-20 15:25 ` Drew Adams
2013-08-20 20:41 ` Stefan Monnier
2013-08-20 21:31 ` Drew Adams
2013-08-20 23:21 ` Stefan Monnier
2013-08-21 0:10 ` Drew Adams
2013-08-21 1:53 ` Stephen J. Turnbull
2013-08-21 2:57 ` Drew Adams
2013-08-21 4:49 ` Stefan Monnier
2013-09-04 20:50 ` Daniel Hackney
2013-09-15 19:33 ` Daniel Colascione
2013-08-21 5:19 ` Dmitri Paduchikh
2013-08-21 20:12 ` Stefan Monnier
2013-09-05 3:30 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvc2xbgvj.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dpaduchikh@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).