From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Lexical byte-compilation warnings cleanup Date: Thu, 22 Aug 2013 16:41:52 -0400 Message-ID: References: <8761uypb7g.fsf@dpaduchikh.invalid> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1377204132 29836 80.91.229.3 (22 Aug 2013 20:42:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 Aug 2013 20:42:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitri Paduchikh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 22 22:42:14 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VCbhs-00022S-IR for ged-emacs-devel@m.gmane.org; Thu, 22 Aug 2013 22:42:12 +0200 Original-Received: from localhost ([::1]:33730 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCbhs-0001oc-72 for ged-emacs-devel@m.gmane.org; Thu, 22 Aug 2013 16:42:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCbhh-0001n4-SR for emacs-devel@gnu.org; Thu, 22 Aug 2013 16:42:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCbha-0006yO-BK for emacs-devel@gnu.org; Thu, 22 Aug 2013 16:42:01 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:18154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCbha-0006yE-5Q for emacs-devel@gnu.org; Thu, 22 Aug 2013 16:41:54 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFHO+LNT/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av8EABK/CFHO+LNT/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="23016204" Original-Received: from 206-248-179-83.dsl.teksavvy.com (HELO pastel.home) ([206.248.179.83]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 22 Aug 2013 16:41:46 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id D2FCA6627C; Thu, 22 Aug 2013 16:41:52 -0400 (EDT) In-Reply-To: <8761uypb7g.fsf@dpaduchikh.invalid> (Dmitri Paduchikh's message of "Thu, 22 Aug 2013 11:05:07 +0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162983 Archived-At: > IMO, this does not explain what happens actually. I would rather prefer > such variant: > Warning: Lexically bound argument shadows dynamic variable %s Better, indeed, thank you, Stefan === modified file 'lisp/emacs-lisp/cconv.el' --- lisp/emacs-lisp/cconv.el 2013-06-14 02:31:28 +0000 +++ lisp/emacs-lisp/cconv.el 2013-08-22 20:41:05 +0000 @@ -552,7 +552,8 @@ (cond ((byte-compile-not-lexical-var-p arg) (byte-compile-log-warning - (format "Argument %S is not a lexical variable" arg))) + (format "Lexical argument shadows the dynamic variable %S" + arg))) ((eq ?& (aref (symbol-name arg) 0)) nil) ;Ignore &rest, &optional, ... (t (let ((varstruct (list arg nil nil nil nil))) (cl-pushnew arg byte-compile-lexical-variables)