From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: trunk r113818: lisp/xml.el (xml-parse-tag-1): Use looking-at. Date: Mon, 12 Aug 2013 21:46:46 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376358424 30241 80.91.229.3 (13 Aug 2013 01:47:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Aug 2013 01:47:04 +0000 (UTC) Cc: Emacs developers , Juanma Barranquero To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 13 03:47:06 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V93hR-00080j-3e for ged-emacs-devel@m.gmane.org; Tue, 13 Aug 2013 03:47:05 +0200 Original-Received: from localhost ([::1]:59580 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V93hQ-0005fc-Jz for ged-emacs-devel@m.gmane.org; Mon, 12 Aug 2013 21:47:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V93hG-0005fI-TF for emacs-devel@gnu.org; Mon, 12 Aug 2013 21:47:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V93h9-0000Vw-Kj for emacs-devel@gnu.org; Mon, 12 Aug 2013 21:46:54 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:64568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V93h9-0000Vr-G1; Mon, 12 Aug 2013 21:46:47 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFLd/Nq/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAs0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av4EABK/CFFLd/Nq/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAs0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="21581656" Original-Received: from 75-119-243-106.dsl.teksavvy.com (HELO pastel.home) ([75.119.243.106]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 12 Aug 2013 21:46:39 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6976662E98; Mon, 12 Aug 2013 21:46:46 -0400 (EDT) In-Reply-To: (Lars Magne Ingebrigtsen's message of "Mon, 12 Aug 2013 18:47:18 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162641 Archived-At: >> What's that you say... "gee, my eyes have been opened as to the value of >> test-suites, and I will start writing one for Gnus forthwith"? ;) > That's what I've been doing the past half hour! Not sure if that means you've been saying it reeeaalllly sslllooowww or repeating it over and over, but in case it doesn't sound like a useful use of your time. BTW, another thing to learn for this is that we shouldn't bother to replace looking-at with looking-at-p. It can be handy to use looking-at-p if it saves us from using save-match-data, but other than that it's not worth the trouble. Stefan