From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook and keymap vars.
Date: Thu, 09 Feb 2017 13:02:22 -0500 [thread overview]
Message-ID: <jwvshnnw8ny.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 87a89vmff5.fsf@zigzag.favinet
> (defvar MODE-map INIT) ; model C
> (define-derived-mode MODE ...)
This is the idiomatic form.
The main benefit is that there's a clear place where the mode map is
defined and `C-h o` will get you there.
> The comment in the removed INIT in the patch (in Subject) shows
> some of the hand-wringing involved w/ the B-C transition. What
The only thing I see in that comment is that you see something ugly, and
that maybe this aesthetic problem is due to the use forward references.
So, is it fair to say that the reason for the patch was to avoid those
forward references?
> (unless EXPECTED-MODE-map-BINDING
Of course, this misfires if the user wants to change this
EXPECTED-MODE-map-BINDING binding ;-)
Stefan
next prev parent reply other threads:[~2017-02-09 18:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170208091858.6699.16542@vcs.savannah.gnu.org>
[not found] ` <20170208091858.F26CA220010@vcs.savannah.gnu.org>
2017-02-08 22:28 ` [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook and keymap vars Stefan Monnier
2017-02-09 17:39 ` Thien-Thi Nguyen
2017-02-09 18:02 ` Stefan Monnier [this message]
2017-02-10 5:15 ` Thien-Thi Nguyen
2017-02-14 14:04 ` Stefan Monnier
2017-02-16 9:41 ` Thien-Thi Nguyen
2017-02-12 11:12 ` Philipp Stephani
2017-02-13 7:29 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvshnnw8ny.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).