From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Thien-Thi Nguyen <ttn@gnu.org>
Subject: Re: [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook and keymap vars.
Date: Wed, 08 Feb 2017 17:28:44 -0500 [thread overview]
Message-ID: <jwva89w48vn.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20170208091858.F26CA220010@vcs.savannah.gnu.org> (Thien-Thi Nguyen's message of "Wed, 8 Feb 2017 09:18:58 +0000 (UTC)")
> * packages/gnugo/gnugo.el (gnugo-board-mode-map):
> Delete defvar; move init to top-level, prior to ‘provide’
> form; conditionalize init on expected ‘?’ binding.
Hmm... I have been installing the exact reverse change in many packages
of the years. IOW this changes "idiomatic code" to "non-idiomatic code".
Both options have advantages and disadvantages, so I'm curious why you
prefer the non-idiomatic way,
Stefan
next parent reply other threads:[~2017-02-08 22:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170208091858.6699.16542@vcs.savannah.gnu.org>
[not found] ` <20170208091858.F26CA220010@vcs.savannah.gnu.org>
2017-02-08 22:28 ` Stefan Monnier [this message]
2017-02-09 17:39 ` [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook and keymap vars Thien-Thi Nguyen
2017-02-09 18:02 ` Stefan Monnier
2017-02-10 5:15 ` Thien-Thi Nguyen
2017-02-14 14:04 ` Stefan Monnier
2017-02-16 9:41 ` Thien-Thi Nguyen
2017-02-12 11:12 ` Philipp Stephani
2017-02-13 7:29 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva89w48vn.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=ttn@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).