From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook and keymap vars. Date: Thu, 09 Feb 2017 13:02:22 -0500 Message-ID: References: <20170208091858.6699.16542@vcs.savannah.gnu.org> <20170208091858.F26CA220010@vcs.savannah.gnu.org> <87a89vmff5.fsf@zigzag.favinet> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1486663421 28541 195.159.176.226 (9 Feb 2017 18:03:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Feb 2017 18:03:41 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 09 19:03:38 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbt4D-0007A6-TN for ged-emacs-devel@m.gmane.org; Thu, 09 Feb 2017 19:03:38 +0100 Original-Received: from localhost ([::1]:39524 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbt4J-0002qS-LF for ged-emacs-devel@m.gmane.org; Thu, 09 Feb 2017 13:03:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbt3F-0002pN-Kj for emacs-devel@gnu.org; Thu, 09 Feb 2017 13:02:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbt3B-0005ff-IJ for emacs-devel@gnu.org; Thu, 09 Feb 2017 13:02:37 -0500 Original-Received: from [195.159.176.226] (port=42243 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cbt3B-0005ev-Cd for emacs-devel@gnu.org; Thu, 09 Feb 2017 13:02:33 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cbt33-0003PI-0w for emacs-devel@gnu.org; Thu, 09 Feb 2017 19:02:25 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 24 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:BBrfN9Y3ROW9ZBcW+A6+ofItPlM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212175 Archived-At: > (defvar MODE-map INIT) ; model C > (define-derived-mode MODE ...) This is the idiomatic form. The main benefit is that there's a clear place where the mode map is defined and `C-h o` will get you there. > The comment in the removed INIT in the patch (in Subject) shows > some of the hand-wringing involved w/ the B-C transition. What The only thing I see in that comment is that you see something ugly, and that maybe this aesthetic problem is due to the use forward references. So, is it fair to say that the reason for the patch was to avoid those forward references? > (unless EXPECTED-MODE-map-BINDING Of course, this misfires if the user wants to change this EXPECTED-MODE-map-BINDING binding ;-) Stefan