* Re: master f131e39: * lisp/cedet/mode-local.el: Clean up name space
[not found] ` <20191025030630.EF0EA20C1E@vcs0.savannah.gnu.org>
@ 2019-11-18 15:07 ` Stefan Kangas
2019-11-19 14:50 ` with-suppressed-warnings ineffective? Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2019-11-18 15:07 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Emacs developers
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> branch: master
> commit f131e396f8a32003b795456130ea37efa6ff41eb
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> * lisp/cedet/mode-local.el: Clean up name space
>
> Mostly renaming functions by adding `mode-local--` to their name
> and leaving an obsolete alias behind, just in case.
>
> (define-child-mode): Make obsolete.
This lead to the following warnings:
ELC cedet/semantic/decorate/mode.elc
‘define-child-mode’ is an obsolete macro (as of 27.1); use
‘define-derived-mode’ instead.
ELC emacs-lisp/chart.elc
‘define-child-mode’ is an obsolete macro (as of 27.1); use
‘define-derived-mode’ instead.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 4+ messages in thread* with-suppressed-warnings ineffective?
2019-11-18 15:07 ` master f131e39: * lisp/cedet/mode-local.el: Clean up name space Stefan Kangas
@ 2019-11-19 14:50 ` Stefan Monnier
2019-11-20 11:29 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2019-11-19 14:50 UTC (permalink / raw)
To: larsi; +Cc: Stefan Kangas, Emacs developers
Hi Lars,
Another brilliant Stefan pointed out that we have undesired warnings:
ELC cedet/semantic/bovine/c.elc
‘define-child-mode’ is an obsolete macro (as of 27.1); use ‘define-derived-mode’ instead.
ELC cedet/semantic/bovine/el.elc
‘define-child-mode’ is an obsolete macro (as of 27.1); use ‘define-derived-mode’ instead.
[ Not sure if the file names are right above. ]
AFAICT these come from
(with-suppressed-warnings ((obsolete define-child-mode))
;; FIXME: We should handle this some other way!
(define-child-mode c++-mode c-mode
"`c++-mode' uses the same parser as `c-mode'."))
and
(with-suppressed-warnings ((obsolete define-child-mode))
;; FIXME: We should handle this some other way!
(define-child-mode lisp-mode emacs-lisp-mode
"Make `lisp-mode' inherit mode local behavior from `emacs-lisp-mode'."))
Any idea why the `with-suppressed-warnings` doesn't actually suppress
the warning? Any hope you could fix it?
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-20 13:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191025030629.28499.81989@vcs0.savannah.gnu.org>
[not found] ` <20191025030630.EF0EA20C1E@vcs0.savannah.gnu.org>
2019-11-18 15:07 ` master f131e39: * lisp/cedet/mode-local.el: Clean up name space Stefan Kangas
2019-11-19 14:50 ` with-suppressed-warnings ineffective? Stefan Monnier
2019-11-20 11:29 ` Lars Ingebrigtsen
2019-11-20 13:45 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).