From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Po Lu <luangruo@yahoo.com>
Cc: Duncan Findlay <duncf@google.com>, emacs-devel@gnu.org
Subject: Re: Set X primary selection with Emacs in xterm
Date: Fri, 03 Jun 2022 08:27:42 -0400 [thread overview]
Message-ID: <jwvk09yylw4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8735gm71kt.fsf@yahoo.com> (Po Lu's message of "Fri, 03 Jun 2022 13:33:54 +0800")
>> --- a/lisp/frame.el
>> +++ b/lisp/frame.el
>> @@ -2164,6 +2164,9 @@ display-selections-p
>> (not (null dos-windows-version))))
>> ((memq frame-type '(x w32 ns pgtk))
>> t)
>> + ((and (memq frame-type '(t))
>> + (eq (terminal-parameter nil 'xterm--set-selection) t))
>> + t)
>
> This doesn't look very clean... I wonder if there is a cleaner way to
> check for this support.
This snippet should belong in `xt-mouse.el` instead, indeed.
Either using an advice, or a generic function, or a `<foo>-predicate`
variable, or by having `xt-mouse.el` set a "generic" frame parameter
which could be called `display-selection-p`.
Stefan
next prev parent reply other threads:[~2022-06-03 12:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 4:03 Set X primary selection with Emacs in xterm Duncan Findlay
2022-06-03 5:33 ` Po Lu
2022-06-03 12:27 ` Stefan Monnier [this message]
2022-06-10 6:36 ` Duncan Findlay
2022-06-03 6:57 ` Eli Zaretskii
2022-06-10 18:10 ` Duncan Findlay
2022-06-10 19:38 ` Eli Zaretskii
2022-06-11 2:03 ` Duncan Findlay
2022-06-03 9:55 ` Jean Louis
2022-06-10 5:49 ` Duncan Findlay
2022-06-10 8:50 ` James Cloos
2022-06-11 6:56 ` Jean Louis
2022-06-15 2:43 ` Duncan Findlay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk09yylw4.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=duncf@google.com \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).