From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Set X primary selection with Emacs in xterm Date: Fri, 03 Jun 2022 08:27:42 -0400 Message-ID: References: <8735gm71kt.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13698"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Duncan Findlay , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 03 14:29:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nx6Qj-0003Pi-Qc for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Jun 2022 14:29:30 +0200 Original-Received: from localhost ([::1]:46398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nx6Qi-0004Vu-HM for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Jun 2022 08:29:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nx6PD-00037o-Ob for emacs-devel@gnu.org; Fri, 03 Jun 2022 08:27:55 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nx6P6-0006Um-SE for emacs-devel@gnu.org; Fri, 03 Jun 2022 08:27:53 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7C2448073F; Fri, 3 Jun 2022 08:27:45 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2E0E18045E; Fri, 3 Jun 2022 08:27:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654259264; bh=UMi7gyNQnVw17vgb4dkW45DNYBHkSakpf9Gk7isMSjc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=TYytISbxCyswibIiOKWMNrT07xtlqFzscATRNKA04BWDsxpZ/uk21SSaByl+4dEBB 4ZxBlUFv3KUEvhStiUHraSYueE7WNkNtlDpFG/yPCbyECxGscf9o6qnsOtNs1OTibb qZslVvXdw62i2foujtiYvfN+iKHNCu0S8LqT7tguSx6sfMuSptWYPG9b/IRmY2eh9I PMw4U6JuHD3duP9InizSh+Eg3bwypEW8lPM8jS9mhzh8yMIg73uIDXN7w9uxJ1hZ7N fvla7/ynn+Y+JHW2z1BT6QabxG6eyKpCDisJZyK8OPDQJf4wQK/WcA68Ny0pUNW3E9 mqOmOrYh2/tuw== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F39F5120341; Fri, 3 Jun 2022 08:27:43 -0400 (EDT) In-Reply-To: <8735gm71kt.fsf@yahoo.com> (Po Lu's message of "Fri, 03 Jun 2022 13:33:54 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290620 Archived-At: >> --- a/lisp/frame.el >> +++ b/lisp/frame.el >> @@ -2164,6 +2164,9 @@ display-selections-p >> (not (null dos-windows-version)))) >> ((memq frame-type '(x w32 ns pgtk)) >> t) >> + ((and (memq frame-type '(t)) >> + (eq (terminal-parameter nil 'xterm--set-selection) t)) >> + t) > > This doesn't look very clean... I wonder if there is a cleaner way to > check for this support. This snippet should belong in `xt-mouse.el` instead, indeed. Either using an advice, or a generic function, or a `-predicate` variable, or by having `xt-mouse.el` set a "generic" frame parameter which could be called `display-selection-p`. Stefan