unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/notmuch-indicator f563869b6a 2/4: Tweak how the keymap is implemented
Date: Wed, 28 Sep 2022 15:15:07 -0400	[thread overview]
Message-ID: <jwvfsgbtjbi.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8735cb2uni.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Wed, 28 Sep 2022 21:58:25 +0300")

>> Oh, and I see elsewhere that you call `mapconcat` with only 2 args,
>> which is a new feature in Emacs-29 whereas the package claims to want to
>> support Emacs-27.
>
> Thanks!  On a more general note, how can we catch cases like this one?

Byte-compile with the oldest Emacs you want to support and check
its warnings?


        Stefan


PS: We make efforts to provide warnings that help people adjust old code
to work better in current and future Emacsen, but we don't provide any
such thing in the other direction.

The closest we have is that `C-h o` will sometimes give you a guess
about the Emacs version in which this var/fun was introduced.  And IIUC
this functionality is not considered as very important.




  reply	other threads:[~2022-09-28 19:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166438787034.3914.5858408463434087870@vcs2.savannah.gnu.org>
     [not found] ` <20220928175750.D5B2CC00615@vcs2.savannah.gnu.org>
2022-09-28 18:30   ` [elpa] externals/notmuch-indicator f563869b6a 2/4: Tweak how the keymap is implemented Stefan Monnier
2022-09-28 18:58     ` Protesilaos Stavrou
2022-09-28 19:15       ` Stefan Monnier [this message]
2022-09-28 20:38       ` Stefan Monnier
2022-09-29  3:26         ` Protesilaos Stavrou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvfsgbtjbi.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=info@protesilaos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).