From: Protesilaos Stavrou <info@protesilaos.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [elpa] externals/notmuch-indicator f563869b6a 2/4: Tweak how the keymap is implemented
Date: Wed, 28 Sep 2022 21:58:25 +0300 [thread overview]
Message-ID: <8735cb2uni.fsf@protesilaos.com> (raw)
In-Reply-To: <jwvleq3tkzx.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Wed, 28 Sep 2022 14:30:01 -0400
>
>> branch: externals/notmuch-indicator
>> commit f563869b6a5e5e12fd791bc109232ed45064f7a7
>> Author: Protesilaos Stavrou <info@protesilaos.com>
>> Commit: Protesilaos Stavrou <info@protesilaos.com>
>>
>> Tweak how the keymap is implemented
>>
>> This continues the work done by Henrik Kjerringvåg in commit f5c9b2e.
>> Henrik does not require to assign copyright to the Free Software
>> Foundation for that commit, as it is within the ~15 line threshold.
> [... 37 lines elided]
> Hmm... really? The new `define-key` will overwrite the binding added in
> the previous call to `notmuch-indicator--format-label`, so if you have
> several elements in `notmuch-indicator-args`, they'll all use the last
> element's `terms` when you click `mouse-1` on them.
Thanks for pointing it out! I reverted to the previous approach.
> While I'm here:
>
>> + (if (and face label)
>> + (format "%s%s " (propertize label 'face face) count)
>> + (format "%s%s " (or label "") count))
>
> can be rewritten to
>
>
> (format "%s%s "
> (if (and face label) (propertize label 'face face)
> (or label "")
> count)
Done. Thank you!
> Oh, and I see elsewhere that you call `mapconcat` with only 2 args,
> which is a new feature in Emacs-29 whereas the package claims to want to
> support Emacs-27.
Thanks! On a more general note, how can we catch cases like this one?
The compiler did not warn about it and the doc string of mapconcat does
not explain as much. I know there is an entry in the NEWS, but having
to check that manually is not easy.
--
Protesilaos Stavrou
https://protesilaos.com
next prev parent reply other threads:[~2022-09-28 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166438787034.3914.5858408463434087870@vcs2.savannah.gnu.org>
[not found] ` <20220928175750.D5B2CC00615@vcs2.savannah.gnu.org>
2022-09-28 18:30 ` [elpa] externals/notmuch-indicator f563869b6a 2/4: Tweak how the keymap is implemented Stefan Monnier
2022-09-28 18:58 ` Protesilaos Stavrou [this message]
2022-09-28 19:15 ` Stefan Monnier
2022-09-28 20:38 ` Stefan Monnier
2022-09-29 3:26 ` Protesilaos Stavrou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735cb2uni.fsf@protesilaos.com \
--to=info@protesilaos.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).