From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/notmuch-indicator f563869b6a 2/4: Tweak how the keymap is implemented Date: Wed, 28 Sep 2022 15:15:07 -0400 Message-ID: References: <166438787034.3914.5858408463434087870@vcs2.savannah.gnu.org> <20220928175750.D5B2CC00615@vcs2.savannah.gnu.org> <8735cb2uni.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36988"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Protesilaos Stavrou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 28 21:17:22 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odcYb-0009Od-8E for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Sep 2022 21:17:21 +0200 Original-Received: from localhost ([::1]:41966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odcYZ-0004jj-ME for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Sep 2022 15:17:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odcWk-0003li-6l for emacs-devel@gnu.org; Wed, 28 Sep 2022 15:15:27 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12164) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odcWh-0002oV-IM for emacs-devel@gnu.org; Wed, 28 Sep 2022 15:15:25 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BA0C880636; Wed, 28 Sep 2022 15:15:20 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5FD6B80365; Wed, 28 Sep 2022 15:15:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1664392519; bh=sgZcizFHt0koEQHQEsYK7IpJq/uzTMBEi2yMFCp6Uy8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pVXzUjz9NC2e2dG/SsJb5OzaPkzGjTOUDr4hsk87T1o0Nr2qhtfGi3qsfqt1ILaAR i5MCh4/iyGg5bz2yi1LUOmZQz6uXotRxkNgfmsNhExTAwl+RdxedwkwOP6ePqrlEjf Fjfr2oTf/ERQAElMrN1isRHt7bSdtYivLh0zvd0Y+DipHbhXgMuWD23ac2ghGbqAZn osole0z3Z6KpN6ThGrGTRE4xNCJsrQCd0izYRkp4Yupb1BLQAReMulP6a1X39m529J KgPdn0JdARC4o8Uk+C519nj50hj6dY+WEr/SHTfJNyaE90FVwhz7EGCnt7IcOJx3BH Go1H+vsQMFZoA== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0AEF1120840; Wed, 28 Sep 2022 15:15:19 -0400 (EDT) In-Reply-To: <8735cb2uni.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Wed, 28 Sep 2022 21:58:25 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296421 Archived-At: >> Oh, and I see elsewhere that you call `mapconcat` with only 2 args, >> which is a new feature in Emacs-29 whereas the package claims to want to >> support Emacs-27. > > Thanks! On a more general note, how can we catch cases like this one? Byte-compile with the oldest Emacs you want to support and check its warnings? Stefan PS: We make efforts to provide warnings that help people adjust old code to work better in current and future Emacsen, but we don't provide any such thing in the other direction. The closest we have is that `C-h o` will sometimes give you a guess about the Emacs version in which this var/fun was introduced. And IIUC this functionality is not considered as very important.