From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: ai_flags in calls to getaddrinfo, broader call for reproducibility check
Date: Tue, 12 Jan 2021 10:14:39 -0500 [thread overview]
Message-ID: <jwvczya42bg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87o8hu9v7a.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 12 Jan 2021 13:49:13 +0100")
>> I suppose if we made the change conditional on some variable as Stefan
>> suggested, default enable, then people could always get back the
>> previous behaviour by disabling it. I dislike that idea because itʼs
>> more work, but perhaps itʼs necessary here.
>
> I tried your patch, and it worked fine for me (using `dns-query' as the
> test case). I don't really see the need for a variable here, either.
Clearly we want this patch to make UDP work, but whether UDP works is
somewhat secondary: The worry is that the patch will introduce
a regression in other places. That makes it hard to test, and that's
why Eli wants someone to take charge of the potential consequences down
the line, which may only show up in hard-to-reproduce corner cases.
Stefan
next prev parent reply other threads:[~2021-01-12 15:14 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 15:06 ai_flags in calls to getaddrinfo Eli Zaretskii
2020-12-31 22:40 ` Robin Tarsiger
2021-01-01 7:43 ` Eli Zaretskii
2021-01-01 11:40 ` Robin Tarsiger
2021-01-01 12:04 ` Robin Tarsiger
2021-01-01 12:48 ` Eli Zaretskii
2021-01-02 0:19 ` Robin Tarsiger
2021-01-03 16:00 ` Eli Zaretskii
2021-01-11 10:47 ` ai_flags in calls to getaddrinfo, broader call for reproducibility check Robin Tarsiger
2021-01-11 12:42 ` Robert Pluim
2021-01-11 15:25 ` Eli Zaretskii
2021-01-11 15:47 ` Robert Pluim
2021-01-11 16:44 ` Eli Zaretskii
2021-01-11 17:07 ` Robin Tarsiger
2021-01-11 17:53 ` Robert Pluim
2021-01-11 18:30 ` Robin Tarsiger
2021-01-11 18:42 ` Robert Pluim
2021-01-11 19:28 ` Stefan Monnier
2021-01-11 20:12 ` Robert Pluim
2021-01-11 20:41 ` Eli Zaretskii
2021-01-11 20:55 ` Stefan Monnier
2021-01-11 21:02 ` Robert Pluim
2021-01-11 21:09 ` Lars Ingebrigtsen
2021-01-11 21:15 ` Robert Pluim
2021-01-11 22:42 ` Lars Ingebrigtsen
2021-01-12 9:40 ` Robert Pluim
2021-01-12 12:49 ` Lars Ingebrigtsen
2021-01-12 13:04 ` Robert Pluim
2021-01-12 14:08 ` Lars Ingebrigtsen
2021-01-12 14:29 ` Robert Pluim
2021-01-12 18:06 ` Lars Ingebrigtsen
2021-01-12 15:14 ` Stefan Monnier [this message]
2021-01-12 15:45 ` Eli Zaretskii
2021-01-12 3:29 ` Eli Zaretskii
2021-01-11 20:46 ` Eli Zaretskii
2021-01-11 20:56 ` Robert Pluim
2021-01-12 15:01 ` Eli Zaretskii
2021-01-12 15:36 ` Robert Pluim
2021-01-12 15:42 ` Eli Zaretskii
2021-01-12 16:00 ` Robert Pluim
2021-01-12 16:05 ` Eli Zaretskii
2021-01-12 17:56 ` Robert Pluim
2021-01-11 19:32 ` Basil L. Contovounesios
2021-01-11 20:19 ` Robert Pluim
2021-01-11 23:57 ` Andy Moreton
2021-01-12 9:44 ` Robert Pluim
2021-01-12 11:56 ` tomas
2021-01-01 10:59 ` ai_flags in calls to getaddrinfo Lars Ingebrigtsen
2021-01-01 12:50 ` Eli Zaretskii
2021-01-02 5:40 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvczya42bg.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).