From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: ai_flags in calls to getaddrinfo, broader call for reproducibility check Date: Tue, 12 Jan 2021 10:14:39 -0500 Message-ID: References: <83sg7mggls.fsf@gnu.org> <83czymc8nq.fsf@gnu.org> <74b7a0a9-0eb3-7944-19d2-f72424ee72d7@dasyatidae.com> <83eeirfqbo.fsf@gnu.org> <87o8hvscfi.fsf@gmail.com> <8335z7fmnz.fsf@gnu.org> <87ft374axc.fsf@gmail.com> <5cb6a0ac-9fe9-bfc2-5642-3423bd043238@dasyatidae.com> <8735z748p1.fsf@gmail.com> <87y2gz2pxf.fsf@gmail.com> <83y2gzdx4o.fsf@gnu.org> <878s8z2nmn.fsf@gmail.com> <87y2gzb2ow.fsf@gnus.org> <87y2gz18gf.fsf@gmail.com> <87o8hvayf5.fsf@gnus.org> <87pn2a1ojx.fsf@gmail.com> <87o8hu9v7a.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13558"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 12 16:15:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzLOE-0003QH-Go for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Jan 2021 16:15:22 +0100 Original-Received: from localhost ([::1]:46430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzLOD-0001ZP-Jg for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Jan 2021 10:15:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzLNe-00018f-Jt for emacs-devel@gnu.org; Tue, 12 Jan 2021 10:14:46 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51013) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzLNc-0002Xy-6j for emacs-devel@gnu.org; Tue, 12 Jan 2021 10:14:45 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DD50C440CC9; Tue, 12 Jan 2021 10:14:42 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9A3AA440C82; Tue, 12 Jan 2021 10:14:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1610464481; bh=cznQmK1cBjp7GDy5KRTrLXdQZBQ5PzWrdfmqSAtKyCU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=TMAkjT6E2Kk7W2Xmt1PU58qpFCqvEWOeHF0N6CGIYIQTzw6Prd7r34A0pAT0miHIK W4FcPff70O0dnjkz+5uzNt9hF4M3JOMwzLuUEKluAw+jSdjltURkAIuveA57WQWdMh Bi4pAi43VRCqEOCexlUpj6ZKpzyztROUkuefxeLYhzzAkiXpQcOPRjckoNcndp0KVQ QkVmXk3S371e3SPL46B3Sa96L37sWduFRwIsAVCeaKQds2/t1YYXihpQl/Avph/rhl fYyrb+CO854RH+0OlcpQcLsSS+9AmYTtv0YOH8iV3Kj8MGOf3+YTHTjjH+ygLXU2Gn uil47A/CSoGMQ== Original-Received: from alfajor (unknown [45.72.224.181]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6DFEC120478; Tue, 12 Jan 2021 10:14:41 -0500 (EST) In-Reply-To: <87o8hu9v7a.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 12 Jan 2021 13:49:13 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262983 Archived-At: >> I suppose if we made the change conditional on some variable as Stefan >> suggested, default enable, then people could always get back the >> previous behaviour by disabling it. I dislike that idea because it=CA=BCs >> more work, but perhaps it=CA=BCs necessary here. > > I tried your patch, and it worked fine for me (using `dns-query' as the > test case). I don't really see the need for a variable here, either. Clearly we want this patch to make UDP work, but whether UDP works is somewhat secondary: The worry is that the patch will introduce a regression in other places. That makes it hard to test, and that's why Eli wants someone to take charge of the potential consequences down the line, which may only show up in hard-to-reproduce corner cases. Stefan