unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Yuan Fu <casouri@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Distinguish between regional undo and undo to the beginning in undo-equiv-table
Date: Wed, 03 Mar 2021 16:29:04 -0500	[thread overview]
Message-ID: <jwvblc0orst.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4890CDDF-E0DD-464B-9268-AD404015129D@gmail.com> (Yuan Fu's message of "Wed, 3 Mar 2021 15:33:13 -0500")

> This patch applies on top of the first one. I added more docstrings since
> you seem to appreciate it.

Great!

> I couldn’t wrap my head around the original tests so I started a new
> one below.

That's perfectly fine.

Earlier you wrote:
> if you undo-in-region, break the undo chain, then undo-in-region again
> with undo-only, ulist would be set to t and it breaks at (setq
> undo-elt (car ulist)).

I don't see which of the tests corresponds to this.
Is it this one:

> +    (should (equal (buffer-string) "abcde")))
> +  ;; Test undo/redo in region.
> +  (with-temp-buffer
> +    (buffer-enable-undo)
> +    (dolist (x '("a" "b" "c" "d" "e"))
> +      (insert x)
> +      (undo-boundary))
>      (should (equal (buffer-string) "abcde"))
> -    ))
> +    (simple-tests--exec '(move-beginning-of-line
> +                          push-mark-command
> +                          forward-char
> +                          forward-char
> +                          undo))
> +    (should (equal (buffer-string) "acde"))
> +    (simple-tests--exec '(undo-only))
> +    (should (equal (buffer-string) "cde"))
> +    (simple-tests--exec '(undo-redo))
> +    (should (equal (buffer-string) "acde"))
> +    (simple-tests--exec '(undo-redo))
> +    (should (equal (buffer-string) "abcde"))))

?

        Stefan




  reply	other threads:[~2021-03-03 21:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 20:40 Distinguish between regional undo and undo to the beginning in undo-equiv-table Yuan Fu
2021-03-02 23:50 ` Stefan Monnier
2021-03-03 15:42   ` Yuan Fu
2021-03-03 16:50     ` Stefan Monnier
2021-03-03 20:33       ` Yuan Fu
2021-03-03 21:29         ` Stefan Monnier [this message]
2021-03-03 21:59           ` Yuan Fu
2021-03-03 22:08             ` Yuan Fu
2021-03-03 22:28             ` Stefan Monnier
2021-03-04 16:18               ` Yuan Fu
2021-03-05 15:57                 ` Stefan Monnier
2021-03-06 17:28                   ` Yuan Fu
2021-03-06 18:40                     ` Stefan Monnier
2021-03-11 17:50                       ` Yuan Fu
2021-03-11 17:54                         ` Stefan Monnier
2021-03-11 21:23                           ` Yuan Fu
2021-03-11 22:41                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvblc0orst.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=casouri@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).