From: Yuan Fu <casouri@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Distinguish between regional undo and undo to the beginning in undo-equiv-table
Date: Wed, 3 Mar 2021 17:08:04 -0500 [thread overview]
Message-ID: <DC9F30C2-AD2B-44EF-B470-79959AC78988@gmail.com> (raw)
In-Reply-To: <A371A62F-E3D8-498A-A9F9-14FFA68D229C@gmail.com>
BTW, I can’t quite get what the comment at simple.el:2920 means:
(puthash list
;; Prevent identity mapping. This can happen if
;; consecutive nils are erroneously in undo list.
(if (or undo-in-region (eq list pending-undo-list))
t
pending-undo-list)
undo-equiv-table)
Is it that if there is (nil nil nil) on the top of buffer-undo-list, the middle one will be considered an undo record and will be passed to primitive-undo? In that case nothing is done and nothing is added to buffer-undo-list? Then should we add a mapping for the buffer-undo-list to t at that point? Or should we just do nothing?
Yuan
next prev parent reply other threads:[~2021-03-03 22:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 20:40 Distinguish between regional undo and undo to the beginning in undo-equiv-table Yuan Fu
2021-03-02 23:50 ` Stefan Monnier
2021-03-03 15:42 ` Yuan Fu
2021-03-03 16:50 ` Stefan Monnier
2021-03-03 20:33 ` Yuan Fu
2021-03-03 21:29 ` Stefan Monnier
2021-03-03 21:59 ` Yuan Fu
2021-03-03 22:08 ` Yuan Fu [this message]
2021-03-03 22:28 ` Stefan Monnier
2021-03-04 16:18 ` Yuan Fu
2021-03-05 15:57 ` Stefan Monnier
2021-03-06 17:28 ` Yuan Fu
2021-03-06 18:40 ` Stefan Monnier
2021-03-11 17:50 ` Yuan Fu
2021-03-11 17:54 ` Stefan Monnier
2021-03-11 21:23 ` Yuan Fu
2021-03-11 22:41 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC9F30C2-AD2B-44EF-B470-79959AC78988@gmail.com \
--to=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).