From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Distinguish between regional undo and undo to the beginning in undo-equiv-table Date: Wed, 03 Mar 2021 16:29:04 -0500 Message-ID: References: <195AF8D0-1BFD-419D-88A1-69EA1FEED4D6@gmail.com> <60DCC8C7-CCA4-4113-88BE-B81A395C494D@gmail.com> <4890CDDF-E0DD-464B-9268-AD404015129D@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39971"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 03 22:30:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHZ4l-000AHc-Kz for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 22:30:35 +0100 Original-Received: from localhost ([::1]:37350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHZ4k-0004et-K2 for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 16:30:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHZ3R-0003Dm-Id for emacs-devel@gnu.org; Wed, 03 Mar 2021 16:29:14 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36599) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHZ3M-00055o-Pe for emacs-devel@gnu.org; Wed, 03 Mar 2021 16:29:12 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0D69C80712; Wed, 3 Mar 2021 16:29:07 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D412480057; Wed, 3 Mar 2021 16:29:04 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614806944; bh=DkCa+KTGJiGadWhxqGayIkm50l3TDT5df13paYIPIFc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=e3LJPywJgWB+ElW5WEo3iEjEh19PQGc3I0/4m3VVHgYw9K/mPW50nGBFBzVuSsHtK Q4Zl594BMxsFTJdvQMEk8a6o+s3PVewFU+lf9DvvGixSY4yJyVkyGQpJJrsgSHxDcJ o4Ni0+w3b9+9CGzYbdA9Byhbvr5la5g2tg8bmBnk7WDlbJWfO18uBzjrmdtdcFjlyH h+keJCIhAHo+Qm411yPZTBr/SCyRGAHaiUNE6JAEN51c6fpDNSUWWdBDgzfGkPNwED zV8g4assnpP45ksRPtUljkj4A1N7itJBuPYz0jzB+TammPFX6Jm2qq2HWLFuzpwYhj MwiQ/Ft4GC28A== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A4B2112014C; Wed, 3 Mar 2021 16:29:04 -0500 (EST) In-Reply-To: <4890CDDF-E0DD-464B-9268-AD404015129D@gmail.com> (Yuan Fu's message of "Wed, 3 Mar 2021 15:33:13 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265916 Archived-At: > This patch applies on top of the first one. I added more docstrings since > you seem to appreciate it. Great! > I couldn=E2=80=99t wrap my head around the original tests so I started a = new > one below. That's perfectly fine. Earlier you wrote: > if you undo-in-region, break the undo chain, then undo-in-region again > with undo-only, ulist would be set to t and it breaks at (setq > undo-elt (car ulist)). I don't see which of the tests corresponds to this. Is it this one: > + (should (equal (buffer-string) "abcde"))) > + ;; Test undo/redo in region. > + (with-temp-buffer > + (buffer-enable-undo) > + (dolist (x '("a" "b" "c" "d" "e")) > + (insert x) > + (undo-boundary)) > (should (equal (buffer-string) "abcde")) > - )) > + (simple-tests--exec '(move-beginning-of-line > + push-mark-command > + forward-char > + forward-char > + undo)) > + (should (equal (buffer-string) "acde")) > + (simple-tests--exec '(undo-only)) > + (should (equal (buffer-string) "cde")) > + (simple-tests--exec '(undo-redo)) > + (should (equal (buffer-string) "acde")) > + (simple-tests--exec '(undo-redo)) > + (should (equal (buffer-string) "abcde")))) ? Stefan