Re: master d9afa1f30fd: Make find-function-regexp also find transient-define-*

Re: master d9afa1f30fd: Make find-function-regexp also find transient-define-*

[Stefan Monnier]

Hmm... I wish we could make the regexp smaller (more discerning) instead
of adding yet more stuff to it.

Maybe we should allow macros like `transient-define-*` to "annotate" the
defined functions with the relevant regexp to find them in the source
(or maybe not the regexp itself but some symbol from which the regexp
can be found)?


        Stefan


Jonas Bernoulli via Mailing list for Emacs changes [2024-02-20 07:59:21] wrote:

> branch: master
> commit d9afa1f30fdf9d00b447fea0a8343397333e172f
> Author: Jonas Bernoulli <jonas@bernoul.li>
> Commit: Jonas Bernoulli <jonas@bernoul.li>
>
>     Make find-function-regexp also find transient-define-*
>     
>     * lisp/emacs-lisp/find-func.el (find-function-regexp): Also find
>     transient-define-prefix, transient-define-suffix,
>     transient-define-infix and transient-define-argument.
> ---
>  lisp/emacs-lisp/find-func.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
> index 63f547ebeb8..411602ef166 100644
> --- a/lisp/emacs-lisp/find-func.el
> +++ b/lisp/emacs-lisp/find-func.el
> @@ -60,6 +60,7 @@
>  ine\\(?:-global\\)?-minor-mode\\|ine-compilation-mode\\|un-cvs-mode\\|\
>  foo\\|\\(?:[^icfgv]\\|g[^r]\\)\\(\\w\\|\\s_\\)+\\*?\\)\\|easy-mmode-define-[a-z-]+\\|easy-menu-define\\|\
>  cl-\\(?:defun\\|defmethod\\|defgeneric\\)\\|\
> +transient-define-\\(?:prefix\\|suffix\\|infix\\|argument\\)\\|\
>  menu-bar-make-toggle\\|menu-bar-make-toggle-command\\)"
>     find-function-space-re
>     "\\('\\|(quote \\)?%s\\(\\s-\\|$\\|[()]\\)")

Re: master d9afa1f30fd: Make find-function-regexp also find transient-define-*

[Jonas Bernoulli]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Hmm... I wish we could make the regexp smaller (more discerning) instead
> of adding yet more stuff to it.
>
> Maybe we should allow macros like `transient-define-*` to "annotate" the
> defined functions with the relevant regexp to find them in the source
> (or maybe not the regexp itself but some symbol from which the regexp
> can be found)?

Agreed.  (I was considering adding a note about that to the commit
message, but figured you would notice and consider that regardless. ;D

Anyway, it might be nice if we could use (declare ...) for this.

     Jonas

> Jonas Bernoulli via Mailing list for Emacs changes [2024-02-20 07:59:21] wrote:
>
>> branch: master
>> commit d9afa1f30fdf9d00b447fea0a8343397333e172f
>> Author: Jonas Bernoulli <jonas@bernoul.li>
>> Commit: Jonas Bernoulli <jonas@bernoul.li>
>>
>>     Make find-function-regexp also find transient-define-*
>>     
>>     * lisp/emacs-lisp/find-func.el (find-function-regexp): Also find
>>     transient-define-prefix, transient-define-suffix,
>>     transient-define-infix and transient-define-argument.
>> ---
>>  lisp/emacs-lisp/find-func.el | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
>> index 63f547ebeb8..411602ef166 100644
>> --- a/lisp/emacs-lisp/find-func.el
>> +++ b/lisp/emacs-lisp/find-func.el
>> @@ -60,6 +60,7 @@
>>  ine\\(?:-global\\)?-minor-mode\\|ine-compilation-mode\\|un-cvs-mode\\|\
>>  foo\\|\\(?:[^icfgv]\\|g[^r]\\)\\(\\w\\|\\s_\\)+\\*?\\)\\|easy-mmode-define-[a-z-]+\\|easy-menu-define\\|\
>>  cl-\\(?:defun\\|defmethod\\|defgeneric\\)\\|\
>> +transient-define-\\(?:prefix\\|suffix\\|infix\\|argument\\)\\|\
>>  menu-bar-make-toggle\\|menu-bar-make-toggle-command\\)"
>>     find-function-space-re
>>     "\\('\\|(quote \\)?%s\\(\\s-\\|$\\|[()]\\)")