unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jonas Bernoulli <jonas@bernoul.li>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master d9afa1f30fd: Make find-function-regexp also find transient-define-*
Date: Sun, 03 Mar 2024 00:49:36 +0100	[thread overview]
Message-ID: <87h6hory7j.fsf@bernoul.li> (raw)
In-Reply-To: <jwvbk7xlwq7.fsf-monnier+emacs@gnu.org>

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Hmm... I wish we could make the regexp smaller (more discerning) instead
> of adding yet more stuff to it.
>
> Maybe we should allow macros like `transient-define-*` to "annotate" the
> defined functions with the relevant regexp to find them in the source
> (or maybe not the regexp itself but some symbol from which the regexp
> can be found)?

Agreed.  (I was considering adding a note about that to the commit
message, but figured you would notice and consider that regardless. ;D

Anyway, it might be nice if we could use (declare ...) for this.

     Jonas

> Jonas Bernoulli via Mailing list for Emacs changes [2024-02-20 07:59:21] wrote:
>
>> branch: master
>> commit d9afa1f30fdf9d00b447fea0a8343397333e172f
>> Author: Jonas Bernoulli <jonas@bernoul.li>
>> Commit: Jonas Bernoulli <jonas@bernoul.li>
>>
>>     Make find-function-regexp also find transient-define-*
>>     
>>     * lisp/emacs-lisp/find-func.el (find-function-regexp): Also find
>>     transient-define-prefix, transient-define-suffix,
>>     transient-define-infix and transient-define-argument.
>> ---
>>  lisp/emacs-lisp/find-func.el | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
>> index 63f547ebeb8..411602ef166 100644
>> --- a/lisp/emacs-lisp/find-func.el
>> +++ b/lisp/emacs-lisp/find-func.el
>> @@ -60,6 +60,7 @@
>>  ine\\(?:-global\\)?-minor-mode\\|ine-compilation-mode\\|un-cvs-mode\\|\
>>  foo\\|\\(?:[^icfgv]\\|g[^r]\\)\\(\\w\\|\\s_\\)+\\*?\\)\\|easy-mmode-define-[a-z-]+\\|easy-menu-define\\|\
>>  cl-\\(?:defun\\|defmethod\\|defgeneric\\)\\|\
>> +transient-define-\\(?:prefix\\|suffix\\|infix\\|argument\\)\\|\
>>  menu-bar-make-toggle\\|menu-bar-make-toggle-command\\)"
>>     find-function-space-re
>>     "\\('\\|(quote \\)?%s\\(\\s-\\|$\\|[()]\\)")



      reply	other threads:[~2024-03-02 23:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <170843396109.30185.17358185403666297260@vcs2.savannah.gnu.org>
     [not found] ` <20240220125921.70EFDC00227@vcs2.savannah.gnu.org>
2024-03-01 16:57   ` master d9afa1f30fd: Make find-function-regexp also find transient-define-* Stefan Monnier
2024-03-02 23:49     ` Jonas Bernoulli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6hory7j.fsf@bernoul.li \
    --to=jonas@bernoul.li \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).