From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook and keymap vars. Date: Wed, 08 Feb 2017 17:28:44 -0500 Message-ID: References: <20170208091858.6699.16542@vcs.savannah.gnu.org> <20170208091858.F26CA220010@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1486592948 19208 195.159.176.226 (8 Feb 2017 22:29:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Feb 2017 22:29:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Thien-Thi Nguyen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 08 23:29:03 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbajQ-0004Tg-0t for ged-emacs-devel@m.gmane.org; Wed, 08 Feb 2017 23:28:56 +0100 Original-Received: from localhost ([::1]:33532 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbajV-00046W-OQ for ged-emacs-devel@m.gmane.org; Wed, 08 Feb 2017 17:29:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbajL-00045H-Uv for emacs-devel@gnu.org; Wed, 08 Feb 2017 17:28:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbajL-0002IL-8r for emacs-devel@gnu.org; Wed, 08 Feb 2017 17:28:51 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:40966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbajH-0002Gy-IP; Wed, 08 Feb 2017 17:28:47 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v18MSiLx004444; Wed, 8 Feb 2017 17:28:45 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 8569D600C1; Wed, 8 Feb 2017 17:28:44 -0500 (EST) In-Reply-To: <20170208091858.F26CA220010@vcs.savannah.gnu.org> (Thien-Thi Nguyen's message of "Wed, 8 Feb 2017 09:18:58 +0000 (UTC)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5943=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5943> : inlines <5682> : streams <1732089> : uri <2373890> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212153 Archived-At: > * packages/gnugo/gnugo.el (gnugo-board-mode-map): > Delete defvar; move init to top-level, prior to =E2=80=98provide=E2= =80=99 > form; conditionalize init on expected =E2=80=98?=E2=80=99 binding. Hmm... I have been installing the exact reverse change in many packages of the years. IOW this changes "idiomatic code" to "non-idiomatic code". Both options have advantages and disadvantages, so I'm curious why you prefer the non-idiomatic way, Stefan