unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: theming
Date: Fri, 08 Jul 2005 10:27:59 -0400	[thread overview]
Message-ID: <jwv8y0hxtmq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <EBCD3E4F-E4CF-45D3-AF60-2A1B7A8DE8B5@gmail.com> (David Reitter's message of "Fri, 8 Jul 2005 13:38:12 +0100")

>> Those customization variables can have a default value that lets them
>> cause different behavior only when under the Aquamacs theme.
>> 
>> So I don't see this as a principal problem once themes work properly.

> Yes, but what about re-definitions of existing functions?
> Defadvice them and put a conditional in the defadvice?

Don't defadvice.  Instead, change the original code.  Of course that means
coming up with a clean customization and convincing us that we should
adopt it.

> However, as long as the (IMHO sensible) patches that Seiji Zenitani and
> I have provided (which only pertain to the OS X version) don't find their
> way into the core or get formally rejected with reasons given,

I'm also surprised that there haven't been any response either way to these
patches.  They seem to provide desirable features, although I can't judge
the code.


        Stefan

  reply	other threads:[~2005-07-08 14:27 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-06 23:58 Sorting of directories in dired Lennart Borgman
2005-07-07  0:13 ` Juanma Barranquero
2005-07-07  6:49   ` Lennart Borgman
2005-07-07  8:02     ` Juanma Barranquero
2005-07-07  8:28       ` Edward O'Connor
2005-07-07 10:11         ` Juanma Barranquero
2005-07-07 12:24           ` David Kastrup
2005-07-07 10:53         ` theming (was: Sorting of directories in dired) John S. Yates, Jr.
2005-07-07 12:17           ` theming Lennart Borgman
2005-07-07 13:31             ` theming Juanma Barranquero
2005-07-07 13:50               ` theming Lennart Borgman
2005-07-07 14:00                 ` theming Juanma Barranquero
2005-07-07 14:24                   ` theming Lennart Borgman
2005-07-07 17:36               ` theming Drew Adams
2005-07-08  4:36               ` theming Richard M. Stallman
2005-07-08 11:05             ` theming John S. Yates, Jr.
2005-07-07 12:22           ` theming (was: Sorting of directories in dired) David Reitter
2005-07-07 14:20             ` theming David Kastrup
2005-07-08 12:38               ` theming David Reitter
2005-07-08 14:27                 ` Stefan Monnier [this message]
2005-07-08 22:01                   ` theming Richard M. Stallman
     [not found]             ` <m1DqbHY-0004RAC@rattlesnake.com>
2005-07-07 18:59               ` theming (was: Sorting of directories in dired) David Reitter
2005-07-07 19:11             ` David Reitter
2005-07-10  5:19             ` Richard M. Stallman
2005-07-10  5:19           ` Richard M. Stallman
2005-07-07 20:37         ` Sorting of directories in dired Eli Zaretskii
2005-07-08  1:12         ` Bill Wohler
2005-07-07 16:43     ` Drew Adams
2005-07-07 21:08       ` Eli Zaretskii
2005-07-07 20:35         ` Drew Adams
2005-07-07 22:41           ` Eli Zaretskii
2005-07-07 22:53             ` Drew Adams
2005-07-08 10:58               ` Eli Zaretskii
2005-07-08 17:40             ` Richard M. Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8y0hxtmq.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).