From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: theming Date: Fri, 08 Jul 2005 10:27:59 -0400 Message-ID: References: <42CC7021.5050606@student.lu.se> <42CCD07F.5010509@student.lu.se> <85pstun1e4.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1120833840 4856 80.91.229.2 (8 Jul 2005 14:44:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 8 Jul 2005 14:44:00 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 08 16:43:48 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Dqu4U-0001Ug-3P for ged-emacs-devel@m.gmane.org; Fri, 08 Jul 2005 16:43:18 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dqu5u-0001XV-0w for ged-emacs-devel@m.gmane.org; Fri, 08 Jul 2005 10:44:46 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dqu1T-0000WO-KY for emacs-devel@gnu.org; Fri, 08 Jul 2005 10:40:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dqu1H-0000SP-1I for emacs-devel@gnu.org; Fri, 08 Jul 2005 10:40:00 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dqu1G-0000ND-Gp for emacs-devel@gnu.org; Fri, 08 Jul 2005 10:39:58 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DqtwR-0007vx-AO; Fri, 08 Jul 2005 10:34:59 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id EB2072CF53D; Fri, 8 Jul 2005 10:28:02 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 74F724AC00A; Fri, 8 Jul 2005 10:27:59 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 5218EE6C1E; Fri, 8 Jul 2005 10:27:59 -0400 (EDT) Original-To: David Reitter In-Reply-To: (David Reitter's message of "Fri, 8 Jul 2005 13:38:12 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-4.848, requis 5, autolearn=not spam, AWL 0.05, BAYES_00 -4.90) X-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40644 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40644 >> Those customization variables can have a default value that lets them >> cause different behavior only when under the Aquamacs theme. >> >> So I don't see this as a principal problem once themes work properly. > Yes, but what about re-definitions of existing functions? > Defadvice them and put a conditional in the defadvice? Don't defadvice. Instead, change the original code. Of course that means coming up with a clean customization and convincing us that we should adopt it. > However, as long as the (IMHO sensible) patches that Seiji Zenitani and > I have provided (which only pertain to the OS X version) don't find their > way into the core or get formally rejected with reasons given, I'm also surprised that there haven't been any response either way to these patches. They seem to provide desirable features, although I can't judge the code. Stefan