From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
Cc: emacs-devel@gnu.org
Subject: Re: bat-mode: Inconsistent fontification. Consider using font-lock-function-name-face
Date: Mon, 09 Sep 2019 17:41:27 -0400 [thread overview]
Message-ID: <jwv4l1ltahz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <cfa93f75-bf75-788a-f9f0-ef38d956c2db@secure.kjonigsen.net> ("Jostein \=\?windows-1252\?Q\?Kj\=F8nigsen\=22's\?\= message of "Mon, 9 Sep 2019 10:49:31 +0200")
> Right now labels have one custom-face defined for bat-mode (bat-label-face),
> and all -uses- of this label via GOTO or CALL-statements has this label
> highlighted using font-lock-constant-face.
>
> My proposal is that we change both these rules to instead be
> font-lock-function-name-face. This solves both constency-problems:
>
> - internal consistency of label/function fontification
FWIW, most modes distinguish function-definitions from
function-references (aka function-calls), and I think that's a good
thing (I like my definition to be highlighted in bold, but I like my
function calls not to be highlighted at all).
Stefan
next prev parent reply other threads:[~2019-09-09 21:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 8:49 bat-mode: Inconsistent fontification. Consider using font-lock-function-name-face Jostein Kjønigsen
2019-09-09 10:48 ` Andy Moreton
2019-09-09 16:09 ` Eli Zaretskii
2019-09-09 17:34 ` Jostein Kjønigsen
2019-09-09 18:10 ` Eli Zaretskii
2019-09-09 19:26 ` Jostein Kjønigsen
2019-09-09 20:32 ` Clément Pit-Claudel
2019-09-09 21:41 ` Stefan Monnier [this message]
2019-09-10 4:29 ` Jostein Kjønigsen
2019-09-10 12:48 ` Stefan Monnier
2019-09-10 14:54 ` Eli Zaretskii
2019-09-10 16:56 ` Jostein Kjønigsen
2019-09-10 18:10 ` Eli Zaretskii
2019-09-10 19:49 ` Michael Albinus
2019-09-18 19:21 ` Jostein Kjønigsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4l1ltahz.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jostein@secure.kjonigsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).