From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: bat-mode: Inconsistent fontification. Consider using font-lock-function-name-face Date: Mon, 09 Sep 2019 17:41:27 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="149224"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Jostein =?windows-1252?Q?Kj=F8nigsen?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 09 23:41:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i7RPz-000ck5-8p for ged-emacs-devel@m.gmane.org; Mon, 09 Sep 2019 23:41:51 +0200 Original-Received: from localhost ([::1]:60880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7RPx-00053F-UT for ged-emacs-devel@m.gmane.org; Mon, 09 Sep 2019 17:41:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43513) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7RPp-000511-1J for emacs-devel@gnu.org; Mon, 09 Sep 2019 17:41:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7RPo-0006dB-21 for emacs-devel@gnu.org; Mon, 09 Sep 2019 17:41:40 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43806) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i7RPn-0006cs-UM for emacs-devel@gnu.org; Mon, 09 Sep 2019 17:41:40 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5A4B7100EC6; Mon, 9 Sep 2019 17:41:39 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D6DA9100EA5; Mon, 9 Sep 2019 17:41:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1568065297; bh=G+cmPHiRoN7BqMzZYaRCD98ew52SAsFZvGwkrHsmzno=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Hd1S3k2VjqRaE8ctmjiOniYVo7KnMftWtvj2z5RfAxJ52n8SbUxmA4qMofNsfbzcu j4xJS0idEOR01d+djOu7lHeheAtGzjS3blxNkXrkwfAjwKgQiVMhJPvaeDJbUTJP0g D8aovyDbuciNl0ej57HDjgkkhcoomxPRwlXMTZ7jsEAs2w7TMyxSTqkkQEYS00P84p bhIvedAh3yzSz+wEyQLVv0RwAU3hDkLQphlOnlb22VzFgPHo8OVB/j2yanCh7sBEIz gpAp5JGxq5ALw9ZLMrIHFZT78RqdHO7BTwOgaBtjLsz1FJqlqaRVP7bDlD7Cab0uBi ALAl7x0xCgM6w== Original-Received: from alfajor (unknown [108.175.224.31]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 92C1C12085B; Mon, 9 Sep 2019 17:41:37 -0400 (EDT) In-Reply-To: ("Jostein \=\?windows-1252\?Q\?Kj\=F8nigsen\=22's\?\= message of "Mon, 9 Sep 2019 10:49:31 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239968 Archived-At: > Right now labels have one custom-face defined for bat-mode (bat-label-face), > and all -uses- of this label via GOTO or CALL-statements has this label > highlighted using font-lock-constant-face. > > My proposal is that we change both these rules to instead be > font-lock-function-name-face. This solves both constency-problems: > > - internal consistency of label/function fontification FWIW, most modes distinguish function-definitions from function-references (aka function-calls), and I think that's a good thing (I like my definition to be highlighted in bold, but I like my function calls not to be highlighted at all). Stefan