From: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
To: Eli Zaretskii <eliz@gnu.org>, Andy Moreton <andrewjmoreton@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: bat-mode: Inconsistent fontification. Consider using font-lock-function-name-face
Date: Mon, 9 Sep 2019 19:34:44 +0200 [thread overview]
Message-ID: <a0b06da1-68b6-977d-7cc5-c88649962519@secure.kjonigsen.net> (raw)
In-Reply-To: <83ftl530zg.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On 9/9/19 6:09 PM, Eli Zaretskii wrote:
>> That is not consistent with c-mode, which uses font-lock-constant-face
>> for both goto statements and labels.
> That's my feeling as well. We fontify labels with
> font-lock-constant-face in other programming modes, so it would feel
> wrong to deviate from that in bat-mode.
>
> As for uses of labels, I see your point about inconsistency, but maybe
> this is justified due to the fact that batch-file labels can be
> CALLed?
If the concept of a label is used consistently across many major-modes,
maybe it would make sense to define this as a first-class font-lock concept?
Basically we could have an official "font-lock-label-face" instead,
which by default would be derived from font-lock-constant-face. That way
people who want labels to look more like functions can customize it on
their end.
Would that be a better option?
--
Kind regards
*Jostein Kjønigsen*
jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
[-- Attachment #2: Type: text/html, Size: 1975 bytes --]
next prev parent reply other threads:[~2019-09-09 17:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 8:49 bat-mode: Inconsistent fontification. Consider using font-lock-function-name-face Jostein Kjønigsen
2019-09-09 10:48 ` Andy Moreton
2019-09-09 16:09 ` Eli Zaretskii
2019-09-09 17:34 ` Jostein Kjønigsen [this message]
2019-09-09 18:10 ` Eli Zaretskii
2019-09-09 19:26 ` Jostein Kjønigsen
2019-09-09 20:32 ` Clément Pit-Claudel
2019-09-09 21:41 ` Stefan Monnier
2019-09-10 4:29 ` Jostein Kjønigsen
2019-09-10 12:48 ` Stefan Monnier
2019-09-10 14:54 ` Eli Zaretskii
2019-09-10 16:56 ` Jostein Kjønigsen
2019-09-10 18:10 ` Eli Zaretskii
2019-09-10 19:49 ` Michael Albinus
2019-09-18 19:21 ` Jostein Kjønigsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0b06da1-68b6-977d-7cc5-c88649962519@secure.kjonigsen.net \
--to=jostein@secure.kjonigsen.net \
--cc=andrewjmoreton@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).