From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Andrii Kolomoiets <andreyk.mad@gmail.com>
Subject: Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188)
Date: Fri, 04 Sep 2020 17:44:44 -0400 [thread overview]
Message-ID: <jwv4kodfc98.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20200904211738.DA94720667@vcs0.savannah.gnu.org> (Dmitry Gutov's message of "Fri, 4 Sep 2020 17:17:38 -0400 (EDT)")
> - (ewoc-invalidate vc-ewoc node))
> + ;; `ewoc-invalidate' will kill line and insert new text,
> + ;; let's keep point column.
> + (let ((p (point)))
> + (ewoc-invalidate vc-ewoc node)
> + (goto-char p)))
Shouldn't this be done in `ewoc-invalidate` instead?
Stefan
next parent reply other threads:[~2020-09-04 21:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200904211737.15548.63989@vcs0.savannah.gnu.org>
[not found] ` <20200904211738.DA94720667@vcs0.savannah.gnu.org>
2020-09-04 21:44 ` Stefan Monnier [this message]
2020-09-05 19:34 ` master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188) Andrii Kolomoiets
2020-09-05 19:41 ` Stefan Monnier
2020-09-13 18:58 ` Andrii Kolomoiets
2020-09-13 20:27 ` Stefan Monnier
2020-09-15 19:14 ` Andrii Kolomoiets
2020-09-15 20:32 ` Stefan Monnier
2020-09-18 14:57 ` Andrii Kolomoiets
2020-09-18 15:23 ` Stefan Monnier
2020-09-18 15:47 ` Andrii Kolomoiets
2020-09-18 15:53 ` Stefan Monnier
2020-09-24 20:21 ` Andrii Kolomoiets
2020-09-28 17:13 ` Stefan Monnier
2020-09-30 20:08 ` Andrii Kolomoiets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4kodfc98.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=andreyk.mad@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).