From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188) Date: Fri, 04 Sep 2020 17:44:44 -0400 Message-ID: References: <20200904211737.15548.63989@vcs0.savannah.gnu.org> <20200904211738.DA94720667@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24488"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Andrii Kolomoiets To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 04 23:45:52 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEJWp-0006Fy-AK for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Sep 2020 23:45:51 +0200 Original-Received: from localhost ([::1]:40636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEJWo-0004k9-6n for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Sep 2020 17:45:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEJVs-0004DL-KY for emacs-devel@gnu.org; Fri, 04 Sep 2020 17:44:52 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24492) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEJVr-0003aZ-1n for emacs-devel@gnu.org; Fri, 04 Sep 2020 17:44:52 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2C6ED440B88; Fri, 4 Sep 2020 17:44:47 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5133E440B56; Fri, 4 Sep 2020 17:44:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599255885; bh=GR7UI9QhQAdsD28Fv/yqfZy5C0mswjzsVtxGQvsvEYA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=JVM/rZDESp2abONzq8qv+e+3aeexO5y3Fyf/M/E0iZqfMhxQLNG93Iu9cAEYRekyI jIFSmPSBW5y5fIWRPZsixOBRZKsyN0LY19aGdDxJS4RC12tL6BbNrbHN5R1ns0zZuO tnOWiLkPN6/Zwy/oi/qxdz4LIu6r1Leue7tZUeWOiyUnVnbHWtdUg8gxNQu4qVBQaM 0aR3VXtZsrph5PpSFjV7077gW4iuvHm/miSMHR5bysP/ndXcSYBdXXshqe9QrgWZiJ P9oojvONUGyuKNEgH7E1WJs+LlbJSyNhqC/erUQ+SkfU9DFQiS2Drwa/BYksln1vaL 8qVqukNOvlm1Q== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DBBFE1204C4; Fri, 4 Sep 2020 17:44:44 -0400 (EDT) In-Reply-To: <20200904211738.DA94720667@vcs0.savannah.gnu.org> (Dmitry Gutov's message of "Fri, 4 Sep 2020 17:17:38 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/04 17:42:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254532 Archived-At: > - (ewoc-invalidate vc-ewoc node)) > + ;; `ewoc-invalidate' will kill line and insert new text, > + ;; let's keep point column. > + (let ((p (point))) > + (ewoc-invalidate vc-ewoc node) > + (goto-char p))) Shouldn't this be done in `ewoc-invalidate` instead? Stefan