Re: master f450798: Don't move point in vc-dir on vc-register/vc-checkin (bug#43188)

[Andrii Kolomoiets <andreyk.mad@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> There are still the case when point position is not saved on
>> ewoc-invalidate - when the buffer is displayed in the other window:
>
> Plus when the buffer is "displayed in a window configuration saved in
> a register", plus when invalidate is called from within
> `save-excursion`, plus ....
>
> Arguably Emacs should provide some way to better handle those issues
> (e.g. provide a hook that can be used to influence the way markers move
> in response to text removal+insertion), but until it does, I recommend
> you live with the occasional suboptimal behavior.

Ok, I will.  But take a look at the attached patch, please.  Few
additional lines and the point is saved in all windows!  Not sure about
those additional cases you mention though, but if the behavior will be
suboptimal, I'll be ready :)

Thanks!


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ewoc-save-point-in-windows.patch --]
[-- Type: text/x-patch, Size: 1790 bytes --]

diff --git a/lisp/emacs-lisp/ewoc.el b/lisp/emacs-lisp/ewoc.el
index 5112322cfd..b71ae5864c 100644
--- a/lisp/emacs-lisp/ewoc.el
+++ b/lisp/emacs-lisp/ewoc.el
@@ -209,10 +209,19 @@ ewoc--refresh-node
          (R (ewoc--node-right node))
          (end (ewoc--node-start-marker R))
          (inhibit-read-only t)
-         (offset (if (= (point) end)
-                     'end
-                   (when (< m (point) end)
-                     (- (point) m)))))
+         (get-offset (lambda (point)
+                       (if (= point end)
+                           'end
+                         (when (< m point end)
+                           (- point m)))))
+         (offset (funcall get-offset (point)))
+         (windows (mapcar (lambda (w)
+                            (unless (eq w (selected-window))
+                              (let ((offset (funcall get-offset
+                                                     (window-point w))))
+                                (when offset
+                                  (cons w offset)))))
+                          (get-buffer-window-list nil nil t))))
     (save-excursion
       ;; First, remove the string from the buffer:
       (delete-region m end)
@@ -224,7 +233,14 @@ ewoc--refresh-node
     (when offset
       (goto-char (if (eq offset 'end)
                      end
-                   (min (+ m offset) (1- end)))))))
+                   (min (+ m offset) (1- end)))))
+    (mapc (lambda (w)
+            (when (window-live-p (car w))
+              (set-window-point (car w)
+                                (if (eq (cdr w) 'end)
+                                    end
+                                  (min (+ m (cdr w)) (1- end))))))
+          windows)))
 
 (defun ewoc--wrap (func)
   (lambda (data)