* Re: feature/native-comp 711b2c8 2/2: * lisp/loadup.el: Don't load pcase on native builds (bug#47025).
[not found] ` <20210310151755.C7D8D211CF@vcs0.savannah.gnu.org>
@ 2021-03-10 23:23 ` Stefan Monnier
2021-03-11 19:29 ` Andrea Corallo via Emacs development discussions.
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2021-03-10 23:23 UTC (permalink / raw)
To: Andrea Corallo; +Cc: emacs-devel
> -(if (byte-code-function-p (symbol-function 'macroexpand-all))
> +(if (or (byte-code-function-p (symbol-function 'macroexpand-all))
> + (subr-native-elisp-p (symbol-function 'macroexpand-all)))
BTW, I find this rather ugly.
I think for this specific case, I will be able to come up with a better
(less ad-hoc/circumstantial) test, but I wonder if this kind of test was
also needed in enough other places that we might think about providing
some other test (like `function-interpreted-p` maybe?).
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: feature/native-comp 711b2c8 2/2: * lisp/loadup.el: Don't load pcase on native builds (bug#47025).
2021-03-10 23:23 ` feature/native-comp 711b2c8 2/2: * lisp/loadup.el: Don't load pcase on native builds (bug#47025) Stefan Monnier
@ 2021-03-11 19:29 ` Andrea Corallo via Emacs development discussions.
2021-03-11 20:36 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Andrea Corallo via Emacs development discussions. @ 2021-03-11 19:29 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> -(if (byte-code-function-p (symbol-function 'macroexpand-all))
>> +(if (or (byte-code-function-p (symbol-function 'macroexpand-all))
>> + (subr-native-elisp-p (symbol-function 'macroexpand-all)))
>
> BTW, I find this rather ugly.
I thought this is very similar to one of the two suggested :)
> I think for this specific case, I will be able to come up with a better
> (less ad-hoc/circumstantial) test, but I wonder if this kind of test was
> also needed in enough other places that we might think about providing
> some other test (like `function-interpreted-p` maybe?).
Yep, `function-interpreted-p' might be handy to have.
Thanks
Andrea
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: feature/native-comp 711b2c8 2/2: * lisp/loadup.el: Don't load pcase on native builds (bug#47025).
2021-03-11 19:29 ` Andrea Corallo via Emacs development discussions.
@ 2021-03-11 20:36 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2021-03-11 20:36 UTC (permalink / raw)
To: Andrea Corallo; +Cc: emacs-devel
>>> -(if (byte-code-function-p (symbol-function 'macroexpand-all))
>>> +(if (or (byte-code-function-p (symbol-function 'macroexpand-all))
>>> + (subr-native-elisp-p (symbol-function 'macroexpand-all)))
>> BTW, I find this rather ugly.
> I thought this is very similar to one of the two suggested :)
It was much more elegant when I wrote it ;-)
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-11 20:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210310151754.12884.67231@vcs0.savannah.gnu.org>
[not found] ` <20210310151755.C7D8D211CF@vcs0.savannah.gnu.org>
2021-03-10 23:23 ` feature/native-comp 711b2c8 2/2: * lisp/loadup.el: Don't load pcase on native builds (bug#47025) Stefan Monnier
2021-03-11 19:29 ` Andrea Corallo via Emacs development discussions.
2021-03-11 20:36 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).